Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Confusion of github_repository in getting started doc #226

Closed
zzxwill opened this issue Feb 6, 2022 · 2 comments
Closed

Confusion of github_repository in getting started doc #226

zzxwill opened this issue Feb 6, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@zzxwill
Copy link
Member

zzxwill commented Feb 6, 2022

What happened?

I got confused about github_repository in https://github.com/crossplane/terrajet/blob/main/docs/generating-a-provider.md?plain=1#L155. After that, I realized it refer to a Terraform resource of the provider.

Maybe we should make it more clear on github_repository.

How can we reproduce it?

@zzxwill zzxwill added the bug Something isn't working label Feb 6, 2022
@turkenh turkenh added documentation Improvements or additions to documentation enhancement New feature or request and removed bug Something isn't working labels Feb 7, 2022
turkenh added a commit to turkenh/terrajet that referenced this issue Feb 9, 2022
@turkenh
Copy link
Member

turkenh commented Feb 9, 2022

Thanks for the feedback @zzxwill

I hope 1db6267 should fix this.

@zzxwill
Copy link
Member Author

zzxwill commented Feb 9, 2022

@turkenh It should. Thanks.

BTW, can you help take a look at this PR? crossplane-contrib/provider-alibaba#72

turkenh added a commit to turkenh/terrajet that referenced this issue Feb 21, 2022
turkenh added a commit to turkenh/terrajet that referenced this issue Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants