Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preflight: add cleanup check to kill daemon process #3815

Merged
merged 1 commit into from
Sep 4, 2023
Merged

preflight: add cleanup check to kill daemon process #3815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/crc/preflight/preflight_daemon_task_check_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,3 +227,12 @@ func checkDaemonPoshScript() error {
func fixDaemonPoshScript() error {
return os.WriteFile(daemonPoshScriptPath, getDaemonPoshScriptContent(), 0600)
}

func killDaemonProcessIfRunning() error {
if daemonRunning() {
if err := killDaemonProcess(); err != nil {
return err
}
}
return nil
}
7 changes: 7 additions & 0 deletions pkg/crc/preflight/preflight_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ var vsockChecks = []Check{
}

var daemonTaskChecks = []Check{
{
cleanupDescription: "Stop daemon process if it is running",
cleanup: killDaemonProcessIfRunning,
flags: CleanUpOnly,

labels: labels{Os: Windows},
},
{
configKeySuffix: "check-daemon-task-posh-script-present",
checkDescription: "Checking if the daemon task powershell script is present",
Expand Down
8 changes: 4 additions & 4 deletions pkg/crc/preflight/preflight_windows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ func TestCountConfigurationOptions(t *testing.T) {
}

func TestCountPreflights(t *testing.T) {
assert.Len(t, getPreflightChecks(false, network.SystemNetworkingMode, constants.GetDefaultBundlePath(preset.OpenShift), preset.OpenShift), 21)
assert.Len(t, getPreflightChecks(true, network.SystemNetworkingMode, constants.GetDefaultBundlePath(preset.OpenShift), preset.OpenShift), 21)
assert.Len(t, getPreflightChecks(false, network.SystemNetworkingMode, constants.GetDefaultBundlePath(preset.OpenShift), preset.OpenShift), 22)
assert.Len(t, getPreflightChecks(true, network.SystemNetworkingMode, constants.GetDefaultBundlePath(preset.OpenShift), preset.OpenShift), 22)

assert.Len(t, getPreflightChecks(false, network.UserNetworkingMode, constants.GetDefaultBundlePath(preset.OpenShift), preset.OpenShift), 20)
assert.Len(t, getPreflightChecks(true, network.UserNetworkingMode, constants.GetDefaultBundlePath(preset.OpenShift), preset.OpenShift), 20)
assert.Len(t, getPreflightChecks(false, network.UserNetworkingMode, constants.GetDefaultBundlePath(preset.OpenShift), preset.OpenShift), 21)
assert.Len(t, getPreflightChecks(true, network.UserNetworkingMode, constants.GetDefaultBundlePath(preset.OpenShift), preset.OpenShift), 21)
}
Loading