Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preflight: add cleanup check to kill daemon process #3815

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

anjannath
Copy link
Member

on windows recently it was observed that stopping the scheduled task did not stop the started daemon process

as workaround this cleanup is added to forcefully kill any running daemon process during 'crc cleanup'. This is needed since only one instance of the daemon is allowed to run, having a running daemon prevents 'crc setup' from starting the daemon scheduled task

on windows recently it was observed that stopping the scheduled
task did not stop the started daemon process

as workaround this cleanup is added to forcefully kill any running
daemon process during 'crc cleanup'. This is needed since only one
instance of the daemon is allowed to run, having a running  daemon
prevents 'crc setup' from starting the daemon scheduled task
@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2023

@anjannath: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc ae97b07 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anjannath anjannath added the has-to-be-in-release This PR need to go in coming release. label Sep 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 4, 2023
@anjannath anjannath merged commit 1f1c4aa into crc-org:main Sep 4, 2023
12 of 13 checks passed
@anjannath anjannath deleted the issue_3812 branch September 4, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved has-to-be-in-release This PR need to go in coming release. lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants