Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect to correct folder id + UI fixes #53

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Redirect to correct folder id + UI fixes #53

merged 4 commits into from
Nov 5, 2024

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Nov 4, 2024 

### ✨ Features

*

### 🐛 Bug Fixes

*

### 🔧 Tech

*

@zatteo zatteo requested a review from ecnivtwelve as a code owner November 4, 2024 15:20
@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 4, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ app/papillon.(hash).js
 15.99KB (+132B +0.81%) -
Unchanged files (5)
Status Path Size Limits
✅ vendors/papillon.(hash).js
 599.54KB -
✅ vendors-papillon.(hash).(hash).min.css
 30.84KB -
✅ img/import-school.(hash).svg
 18.15KB -
✅ img/pronote.(hash).svg
 1.83KB -
✅ app-papillon.(hash).min.css
 20B -

Total files change +132B +0.02%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 615.64KB (+132B +0.02%) -
Unchanged groups (2)
Status Path Size Limits
✅ **/*.css
 30.86KB -
✅ img/.
 19.97KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

cballevre
cballevre approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@cballevre cballevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zatteo zatteo changed the title Fix UI issues Redirect to correct folder id + UI fixes Nov 4, 2024
@zatteo zatteo requested a review from cballevre November 4, 2024 16:25
cballevre
cballevre approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@cballevre cballevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment, it looks good to me 👍

src/queries/index.js Outdated Show resolved Hide resolved
zatteo added 2 commits November 5, 2024 09:12
@zatteo
fix: Redirect to correct folder id thanks to accounts and triggers
9f63b4f 
The good way to get the folder id of a pronote account is with
accounts and triggers like in this commit.
@zatteo
fix: Do not embed an a element in a element
8657887 
Let's forward the "href" and "_target" props to NavLink to avoid the
need of an a element before the NavLink.
@zatteo zatteo merged commit 0d5c51d into master Nov 5, 2024
2 checks passed
@zatteo zatteo deleted the fix/folder-linj branch November 5, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cballevre cballevre cballevre approved these changes

@ecnivtwelve ecnivtwelve Awaiting requested review from ecnivtwelve ecnivtwelve is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zatteo @cballevre