fix: Do not embed an a element in a element

Let's forward the "href" and "_target" props to NavLink to avoid the need of an a element before the NavLink.
cozy · Nov 5, 2024 · 8657887 · 8657887
1 parent 9f63b4f
commit 8657887
Showing 1 changed file with 17 additions and 27 deletions.
diff --git a/src/components/AppLayout.jsx b/src/components/AppLayout.jsx
@@ -34,12 +34,9 @@ const ExampleRouterNavLink = ({
   className,
   active,
   activeClassName,
-  onClick
+  ...rest
 }) => (
-  <a
-    onClick={onClick}
-    className={cx(className, active ? activeClassName : null)}
-  >
+  <a className={cx(className, active ? activeClassName : null)} {...rest}>
     {children}
   </a>
 )
@@ -112,28 +109,21 @@ const AppLayout = () => {
             </NavLink>
           </NavItem>
           {currentAccountFolderLink && (
-            <a
-              href={currentAccountFolderLink}
-              target="_blank"
-              rel="noreferrer"
-              style={{ textDecoration: 'none' }}
-            >
-              <NavItem>
-                <NavLink>
-                  <NavIcon icon={FolderIcon} />
-                  <NavText>{t('Sidebar.documents')}</NavText>
-                  {!isMobile && (
-                    <Icon
-                      icon={OpenappIcon}
-                      style={{
-                        marginLeft: 'auto',
-                        marginRight: 8
-                      }}
-                    />
-                  )}
-                </NavLink>
-              </NavItem>
-            </a>
+            <NavItem>
+              <NavLink href={currentAccountFolderLink} target="_blank">
+                <NavIcon icon={FolderIcon} />
+                <NavText>{t('Sidebar.documents')}</NavText>
+                {!isMobile && (
+                  <Icon
+                    icon={OpenappIcon}
+                    style={{
+                      marginLeft: 'auto',
+                      marginRight: 8
+                    }}
+                  />
+                )}
+              </NavLink>
+            </NavItem>
           )}
         </Nav>
       </Sidebar>