Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes various padding issues on KonnectorBlock #1893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

fix: Fixes various padding issues on KonnectorBlock #1893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/cozy-harvest-lib/src/components/KonnectorBlock.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const KonnectorBlock = ({ file }) => {
if (!konnector) {
return (
<div data-testid="KonnectorBlock-spinner">
<Spinner className="u-flex u-flex-justify-center u-p-2" size="large" />
<Spinner className="u-flex u-flex-justify-center u-p-1" size="large" />
</div>
)
}
Expand All @@ -70,16 +70,16 @@ const KonnectorBlock = ({ file }) => {

if (fatalError) {
return (
<Typography className="u-pv-1-half u-ph-2" variant="body1">
<Typography className="u-p-1" variant="body1">
<Markdown source={fatalError} />
</Typography>
)
}

return (
<List>
<List className="u-pv-0">
<ListItem
className="u-ph-2 u-h-3"
className="u-ph-1 u-h-3"
button
component="a"
href={link}
Expand Down Expand Up @@ -113,7 +113,7 @@ const KonnectorBlock = ({ file }) => {

<Divider component="li" />

<ListItem className="u-ph-2" button {...vendorLink}>
<ListItem className="u-ph-1" button {...vendorLink}>
<ListItemIcon>
<Icon icon={GlobeIcon} color="var(--primaryTextColor)" />
</ListItemIcon>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem que sur ui, je suis preneur d'un point zoom qu'on regarde ensemble... typiquement si c'est pertinent on devrait peut-être alors faire un BC côté ui...

Copy link
Contributor Author

@PolariTOON PolariTOON Nov 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En desktop, ça ne devrait rien changer visuellement, parce que le padding en question sera juste reporté sur le parent : https://github.com/cozy/cozy-ui/pull/2307/files#diff-9bc473c558a549f9218289b09ad5c9c4457148ecd27383f3d3591d2be0e49308R27
En mobile, ça diminuera le padding total, qui est censé être plus faible que sur desktop. En tout cas, c'est comme ça dans les autres blocs dans les specs.

Expand Down