-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixes various padding issues on KonnectorBlock
#1893
base: master
Are you sure you want to change the base?
fix: Fixes various padding issues on KonnectorBlock
#1893
Conversation
@@ -113,7 +113,7 @@ const KonnectorBlock = ({ file }) => { | |||
|
|||
<Divider component="li" /> | |||
|
|||
<ListItem className="u-ph-2" button {...vendorLink}> | |||
<ListItem className="u-ph-1" button {...vendorLink}> | |||
<ListItemIcon> | |||
<Icon icon={GlobeIcon} color="var(--primaryTextColor)" /> | |||
</ListItemIcon> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem que sur ui, je suis preneur d'un point zoom qu'on regarde ensemble... typiquement si c'est pertinent on devrait peut-être alors faire un BC côté ui...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En desktop, ça ne devrait rien changer visuellement, parce que le padding en question sera juste reporté sur le parent : https://github.com/cozy/cozy-ui/pull/2307/files#diff-9bc473c558a549f9218289b09ad5c9c4457148ecd27383f3d3591d2be0e49308R27
En mobile, ça diminuera le padding total, qui est censé être plus faible que sur desktop. En tout cas, c'est comme ça dans les autres blocs dans les specs.
@PolariTOON what is the status of this PR? |
This isn't prioritized in any way. This PR is untested and relies on cozy/cozy-ui/pull/2307 (which has been tested and is ready in my opinion) and thus blocked on it, which isn't prioritized either. |
A small fix, for consistency with new paddings in cozy/cozy-ui#2307.