Use new service fee query #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
reviewed
Nov 19, 2024
| @@ -436,13 +436,6 @@ def construct_payout_dataframe( | |||
| config.reward_config.reward_token_address.address | |||
| ) | |||
|
|
|||
| # 7. Missing service fee is treated as new solver | |||
There was a problem hiding this comment.
This was removed since the meaning of missing entries changed, right? Before it was an indication of missing data for new solvers. Now it could also just be a solver who is not in the COW bonding pool.
Not important for today's payouts, but it might be useful to reactivate a check restricted to missing service fee status for solvers in the COW bonding pool.
There was a problem hiding this comment.
Yes, indeed, the previous query was supposed to return an entry for every single active (vouched) solver, while this one only cares about CoW DAO bonding pool solvers. So if we want to bring back the check, we need to restrict it to the CoW DAO solvers
fhenneke
approved these changes
Nov 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the query id that is used for computing whether a service fee should be applied. Some minor simplifications in the code are needed.
This PR should be merged only after this dune-queries has been properly reviewed: cowprotocol/dune-queries#66