-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix spelling errors #1860
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -14,13 +14,13 @@ module ccv_pss_model { | |||||
} | ||||||
|
||||||
action OptIn_Deterministic(consumer: Chain, validator: Node): bool = { | ||||||
val res = OptIn(currentState, consumer, validator) | ||||||
val res = option(currentState, consumer, validator) | ||||||
all { | ||||||
currentState' = res.newState, | ||||||
trace' = trace.append( | ||||||
{ | ||||||
...emptyAction, | ||||||
kind: "OptIn", | ||||||
kind: "option", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update the action kind to - kind: "option",
+ kind: "Option", Committable suggestion
Suggested change
|
||||||
consumerChain: consumer, | ||||||
validator: validator | ||||||
} | ||||||
|
@@ -83,7 +83,7 @@ module ccv_pss_model { | |||||
|
||||||
val CanOptIn = { | ||||||
not( | ||||||
trace[length(trace)-1].kind == "OptIn" | ||||||
trace[length(trace)-1].kind == "option" | ||||||
and | ||||||
trace[length(trace)-1].expectedError == "" | ||||||
) | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -27,7 +27,7 @@ func NewHandler(k *keeper.Keeper) sdk.Handler { | |||||
res, err := msgServer.SubmitConsumerDoubleVoting(sdk.WrapSDKContext(ctx), msg) | ||||||
return sdk.WrapServiceResult(ctx, res, err) | ||||||
case *types.MsgOptIn: | ||||||
res, err := msgServer.OptIn(sdk.WrapSDKContext(ctx), msg) | ||||||
res, err := msgServer.option(sdk.WrapSDKContext(ctx), msg) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renaming - res, err := msgServer.option(sdk.WrapSDKContext(ctx), msg)
+ res, err := msgServer.Option(sdk.WrapSDKContext(ctx), msg) Committable suggestion
Suggested change
|
||||||
return sdk.WrapServiceResult(ctx, res, err) | ||||||
case *types.MsgOptOut: | ||||||
res, err := msgServer.OptOut(sdk.WrapSDKContext(ctx), msg) | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -22,10 +22,10 @@ | |||||
// NewMsgServerImpl returns an implementation of the bank MsgServer interface | ||||||
// for the provided Keeper. | ||||||
func NewMsgServerImpl(keeper *Keeper) types.MsgServer { | ||||||
return &msgServer{Keeper: keeper} | ||||||
Check failure on line 25 in x/ccv/provider/keeper/msg_server.go GitHub Actions / test-integration
Check failure on line 25 in x/ccv/provider/keeper/msg_server.go GitHub Actions / tests
Check failure on line 25 in x/ccv/provider/keeper/msg_server.go GitHub Actions / Analyze
Check failure on line 25 in x/ccv/provider/keeper/msg_server.go GitHub Actions / Analyze
Check failure on line 25 in x/ccv/provider/keeper/msg_server.go GitHub Actions / test-integration
Check failure on line 25 in x/ccv/provider/keeper/msg_server.go GitHub Actions / tests
Check failure on line 25 in x/ccv/provider/keeper/msg_server.go GitHub Actions / Analyze
Check failure on line 25 in x/ccv/provider/keeper/msg_server.go GitHub Actions / test-integration
Check failure on line 25 in x/ccv/provider/keeper/msg_server.go GitHub Actions / tests
Check failure on line 25 in x/ccv/provider/keeper/msg_server.go GitHub Actions / Analyze
|
||||||
} | ||||||
|
||||||
var _ types.MsgServer = msgServer{} | ||||||
Check failure on line 28 in x/ccv/provider/keeper/msg_server.go GitHub Actions / test-integration
Check failure on line 28 in x/ccv/provider/keeper/msg_server.go GitHub Actions / tests
Check failure on line 28 in x/ccv/provider/keeper/msg_server.go GitHub Actions / Analyze
Check failure on line 28 in x/ccv/provider/keeper/msg_server.go GitHub Actions / Analyze
Check failure on line 28 in x/ccv/provider/keeper/msg_server.go GitHub Actions / test-integration
Check failure on line 28 in x/ccv/provider/keeper/msg_server.go GitHub Actions / tests
Check failure on line 28 in x/ccv/provider/keeper/msg_server.go GitHub Actions / Analyze
Check failure on line 28 in x/ccv/provider/keeper/msg_server.go GitHub Actions / test-integration
Check failure on line 28 in x/ccv/provider/keeper/msg_server.go GitHub Actions / tests
Check failure on line 28 in x/ccv/provider/keeper/msg_server.go GitHub Actions / Analyze
|
||||||
|
||||||
// AssignConsumerKey defines a method to assign a consensus key on a consumer chain | ||||||
// for a given validator on the provider | ||||||
|
@@ -137,7 +137,7 @@ | |||||
return &types.MsgSubmitConsumerDoubleVotingResponse{}, nil | ||||||
} | ||||||
|
||||||
func (k msgServer) OptIn(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) { | ||||||
func (k msgServer) option(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renaming - func (k msgServer) option(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) {
+ func (k msgServer) Option(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) { Committable suggestion
Suggested change
|
||||||
ctx := sdk.UnwrapSDKContext(goCtx) | ||||||
|
||||||
valAddress, err := sdk.ValAddressFromBech32(msg.ProviderAddr) | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming RPC method from
OptIn
tooption
might cause confusion due to the non-standard naming convention.Committable suggestion