chore: fix spelling errors #1860
Conversation
github-actions
bot
added
C:Testing
WalkthroughWalkthroughThe recent updates primarily involve renaming the Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (9)
Files skipped from review due to trivial changes (2)
Additional Context UsedGitHub Check Runs (4)
Path-based Instructions (4)
Additional comments not posted (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -27,7 +27,7 @@ func NewHandler(k *keeper.Keeper) sdk.Handler { | |||
| res, err := msgServer.SubmitConsumerDoubleVoting(sdk.WrapSDKContext(ctx), msg) | |||
| return sdk.WrapServiceResult(ctx, res, err) | |||
| case *types.MsgOptIn: | |||
| res, err := msgServer.OptIn(sdk.WrapSDKContext(ctx), msg) | |||
| res, err := msgServer.option(sdk.WrapSDKContext(ctx), msg) | |||
There was a problem hiding this comment.
Renaming OptIn to option might cause confusion due to the non-standard naming convention.
- res, err := msgServer.option(sdk.WrapSDKContext(ctx), msg)
+ res, err := msgServer.Option(sdk.WrapSDKContext(ctx), msg)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| res, err := msgServer.option(sdk.WrapSDKContext(ctx), msg) | |
| res, err := msgServer.Option(sdk.WrapSDKContext(ctx), msg) |
| all { | ||
| currentState' = res.newState, | ||
| trace' = trace.append( | ||
| { | ||
| ...emptyAction, | ||
| kind: "OptIn", | ||
| kind: "option", |
There was a problem hiding this comment.
Update the action kind to Option to maintain consistency with naming conventions.
- kind: "option",
+ kind: "Option",Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| kind: "option", | |
| kind: "Option", |
| rpc AssignConsumerKey(MsgAssignConsumerKey) returns (MsgAssignConsumerKeyResponse); | ||
| rpc SubmitConsumerMisbehaviour(MsgSubmitConsumerMisbehaviour) returns (MsgSubmitConsumerMisbehaviourResponse); | ||
| rpc SubmitConsumerDoubleVoting(MsgSubmitConsumerDoubleVoting) returns (MsgSubmitConsumerDoubleVotingResponse); | ||
| rpc OptIn(MsgOptIn) returns (MsgOptInResponse); | ||
| rpc option(MsgOptIn) returns (MsgOptInResponse); |
There was a problem hiding this comment.
Renaming RPC method from OptIn to option might cause confusion due to the non-standard naming convention.
- rpc option(MsgOptIn) returns (MsgOptInResponse);
+ rpc Option(MsgOptIn) returns (MsgOptInResponse);Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| rpc option(MsgOptIn) returns (MsgOptInResponse); | |
| rpc Option(MsgOptIn) returns (MsgOptInResponse); |
| @@ -137,7 +137,7 @@ | |||
| return &types.MsgSubmitConsumerDoubleVotingResponse{}, nil | |||
| } | |||
|
|
|||
| func (k msgServer) OptIn(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) { | |||
| func (k msgServer) option(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) { | |||
There was a problem hiding this comment.
Renaming OptIn to option might cause confusion due to the non-standard naming convention.
- func (k msgServer) option(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) {
+ func (k msgServer) Option(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| func (k msgServer) option(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) { | |
| func (k msgServer) Option(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) { |
This PR fixes typos in the codebase.
Please review it, and merge if everything is fine.
If there are proto changes, run
make proto-genand commit the changes.Summary by CodeRabbit
OptInfunctionality tooptionacross various modules and tests, affecting how users opt-in or opt-out in configurations and actions.OptIntooptionin several files, ensuring consistency across the codebase.