-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix spelling errors #1855
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,11 +11,11 @@ | |
|
||
|
||
// Msg defines the Msg service. | ||
service Msg { | ||
Check failure on line 14 in proto/interchain_security/ccv/provider/v1/tx.proto GitHub Actions / break-check
Check failure on line 14 in proto/interchain_security/ccv/provider/v1/tx.proto GitHub Actions / break-check
|
||
rpc AssignConsumerKey(MsgAssignConsumerKey) returns (MsgAssignConsumerKeyResponse); | ||
rpc SubmitConsumerMisbehaviour(MsgSubmitConsumerMisbehaviour) returns (MsgSubmitConsumerMisbehaviourResponse); | ||
rpc SubmitConsumerDoubleVoting(MsgSubmitConsumerDoubleVoting) returns (MsgSubmitConsumerDoubleVotingResponse); | ||
rpc OptIn(MsgOptIn) returns (MsgOptInResponse); | ||
rpc option(MsgOptIn) returns (MsgOptInResponse); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider renaming |
||
rpc OptOut(MsgOptOut) returns (MsgOptOutResponse); | ||
rpc SetConsumerCommissionRate(MsgSetConsumerCommissionRate) returns (MsgSetConsumerCommissionRateResponse); | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2274,7 +2274,7 @@ type OptInAction struct { | |
Validator ValidatorID | ||
} | ||
|
||
func (tr TestConfig) optIn(action OptInAction, target ExecutionTarget, verbose bool) { | ||
func (tr TestConfig) option(action OptInAction, target ExecutionTarget, verbose bool) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also not a typo. |
||
// Note: to get error response reported back from this command '--gas auto' needs to be set. | ||
gas := "auto" | ||
// Unfortunately, --gas auto does not work with CometMock. so when using CometMock, just use --gas 9000000 then | ||
|
@@ -2283,7 +2283,7 @@ func (tr TestConfig) optIn(action OptInAction, target ExecutionTarget, verbose b | |
} | ||
|
||
// Use: "opt-in [consumer-chain-id] [consumer-pubkey]", | ||
optIn := fmt.Sprintf( | ||
option := fmt.Sprintf( | ||
`%s tx provider opt-in %s --from validator%s --chain-id %s --home %s --node %s --gas %s --keyring-backend test -y -o json`, | ||
tr.chainConfigs[ChainID("provi")].BinaryName, | ||
string(tr.chainConfigs[action.Chain].ChainId), | ||
|
@@ -2296,11 +2296,11 @@ func (tr TestConfig) optIn(action OptInAction, target ExecutionTarget, verbose b | |
|
||
cmd := target.ExecCommand( | ||
"/bin/bash", "-c", | ||
optIn, | ||
option, | ||
) | ||
|
||
if verbose { | ||
fmt.Println("optIn cmd:", cmd.String()) | ||
fmt.Println("option cmd:", cmd.String()) | ||
} | ||
|
||
bz, err := cmd.CombinedOutput() | ||
|
@@ -2333,7 +2333,7 @@ func (tr TestConfig) optOut(action OptOutAction, target ExecutionTarget, verbose | |
} | ||
|
||
// Use: "opt-out [consumer-chain-id]", | ||
optIn := fmt.Sprintf( | ||
option := fmt.Sprintf( | ||
`%s tx provider opt-out %s --from validator%s --chain-id %s --home %s --node %s --gas %s --keyring-backend test -y -o json`, | ||
tr.chainConfigs[ChainID("provi")].BinaryName, | ||
string(tr.chainConfigs[action.Chain].ChainId), | ||
|
@@ -2346,7 +2346,7 @@ func (tr TestConfig) optOut(action OptOutAction, target ExecutionTarget, verbose | |
|
||
cmd := target.ExecCommand( | ||
"/bin/bash", "-c", | ||
optIn, | ||
option, | ||
) | ||
|
||
if verbose { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ func NewHandler(k *keeper.Keeper) sdk.Handler { | |
res, err := msgServer.SubmitConsumerDoubleVoting(sdk.WrapSDKContext(ctx), msg) | ||
return sdk.WrapServiceResult(ctx, res, err) | ||
case *types.MsgOptIn: | ||
res, err := msgServer.OptIn(sdk.WrapSDKContext(ctx), msg) | ||
res, err := msgServer.option(sdk.WrapSDKContext(ctx), msg) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renaming Consider renaming |
||
return sdk.WrapServiceResult(ctx, res, err) | ||
case *types.MsgOptOut: | ||
res, err := msgServer.OptOut(sdk.WrapSDKContext(ctx), msg) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a typo!
This could have been called
OptInValidator
, though.