chore: fix spelling errors #1855
Conversation
WalkthroughWalkthroughThe recent updates involve renaming the Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (9)
Files skipped from review as they are similar to previous changes (7)
Additional Context UsedGitHub Check Runs (3)
Path-based Instructions (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
C:Testing
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Out of diff range and nitpick comments (1)
tests/e2e/actions.go (1)
[!TIP]
Codebase VerificationThe script results confirm that the
--gas autosetting is indeed mentioned in the context of its incompatibility with CometMock within thetests/e2e/actions.gofile. This aligns with the original concern raised in the review comment about the need to verify the compatibility of--gas autowith CometMock, as it affects execution in different environments.Given this confirmation, the review comment is accurate and the concern about the compatibility of
--gas autowith CometMock is valid and should be addressed in the codebase.Conclusion:
- The use of
--gas autoand its noted incompatibility with CometMock is confirmed by the script results.- The renaming from
optIntooptionis consistent with the PR objectives and has been implemented correctly.Action Items:
- Address the compatibility issue of
--gas autowith CometMock to ensure consistent behavior across different testing environments.Analysis chain
Line range hint
2277-2303: Renaming fromoptIntooptionis consistent with PR objectives.Please verify the compatibility of
--gas autowith CometMock as it might affect the execution in different environments.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any references to `--gas auto` in the context of CometMock usage across the codebase. # Find files that contain `--gas auto` and check for any CometMock configurations. rg --files-with-matches --type go $'--gas auto' | while read file; do # Search for CometMock configurations in the same files. Expect: No matches if incompatible. rg 'CometMock' "$file" doneLength of output: 473
Script:
#!/bin/bash # Description: Check for any references to `--gas auto` in the context of CometMock usage across the codebase. # Find files that contain `--gas auto` and check for any CometMock configurations. rg --files-with-matches --type go '\-\-gas auto' | while read file; do # Search for CometMock configurations in the same files. Expect: No matches if incompatible. rg 'CometMock' "$file" doneLength of output: 887
| @@ -27,7 +27,7 @@ func NewHandler(k *keeper.Keeper) sdk.Handler { | |||
| res, err := msgServer.SubmitConsumerDoubleVoting(sdk.WrapSDKContext(ctx), msg) | |||
| return sdk.WrapServiceResult(ctx, res, err) | |||
| case *types.MsgOptIn: | |||
| res, err := msgServer.OptIn(sdk.WrapSDKContext(ctx), msg) | |||
| res, err := msgServer.option(sdk.WrapSDKContext(ctx), msg) | |||
There was a problem hiding this comment.
Renaming OptIn to option might not adhere to Go naming conventions.
Consider renaming option to Option to follow Go's convention of capitalizing exported method names. This change ensures consistency and clarity in method visibility across the codebase.
| @@ -15,7 +15,7 @@ service Msg { | |||
| rpc AssignConsumerKey(MsgAssignConsumerKey) returns (MsgAssignConsumerKeyResponse); | |||
| rpc SubmitConsumerMisbehaviour(MsgSubmitConsumerMisbehaviour) returns (MsgSubmitConsumerMisbehaviourResponse); | |||
| rpc SubmitConsumerDoubleVoting(MsgSubmitConsumerDoubleVoting) returns (MsgSubmitConsumerDoubleVotingResponse); | |||
| rpc OptIn(MsgOptIn) returns (MsgOptInResponse); | |||
| rpc option(MsgOptIn) returns (MsgOptInResponse); | |||
There was a problem hiding this comment.
This is not a typo!
This could have been called OptInValidator, though.
| @@ -2274,7 +2274,7 @@ type OptInAction struct { | |||
| Validator ValidatorID | |||
| } | |||
|
|
|||
| func (tr TestConfig) optIn(action OptInAction, target ExecutionTarget, verbose bool) { | |||
| func (tr TestConfig) option(action OptInAction, target ExecutionTarget, verbose bool) { | |||
github-prbot
force-pushed
the
bot/fix-typos
branch
from
a671ce2 to
69f1c4f
Compare
| rpc AssignConsumerKey(MsgAssignConsumerKey) returns (MsgAssignConsumerKeyResponse); | ||
| rpc SubmitConsumerMisbehaviour(MsgSubmitConsumerMisbehaviour) returns (MsgSubmitConsumerMisbehaviourResponse); | ||
| rpc SubmitConsumerDoubleVoting(MsgSubmitConsumerDoubleVoting) returns (MsgSubmitConsumerDoubleVotingResponse); | ||
| rpc OptIn(MsgOptIn) returns (MsgOptInResponse); | ||
| rpc option(MsgOptIn) returns (MsgOptInResponse); |
There was a problem hiding this comment.
Consider renaming option to Option to follow typical naming conventions for RPC methods, which usually start with a capital letter. This change ensures consistency and clarity in method visibility across the codebase.
|
OptIn might be close to option in terms of letters, but these are different things |
This PR fixes typos in the codebase.
Please review it, and merge if everything is fine.
If there are proto changes, run
make proto-genand commit the changes.