Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update migration handling for provider consensus v2->v3 #1536

Merged
merged 2 commits into from
Dec 21, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix typos and nits
  • Loading branch information
MSalopek committed Dec 21, 2023
commit 0c75540bdef584a74c8653cc3b3f408ba7d3544c
2 changes: 1 addition & 1 deletion x/ccv/provider/keeper/throttle_legacy.go
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ const (
vscMaturedPacketData
)

// Deprecated: LegacyGetAllThrottledPacketData is deprecated is deprecated for ICS >= v4.0.0.
// Deprecated: LegacyGetAllThrottledPacketData is deprecated for ICS >= v4.0.0.
// LegacyGetAllThrottledPacketData returns all throttled packet data that was queued on the provider for a given consumer chain.
func (k Keeper) LegacyGetAllThrottledPacketData(ctx sdktypes.Context, consumerChainID string) (
MSalopek marked this conversation as resolved.
Show resolved Hide resolved
slashData []ccvtypes.SlashPacketData, vscMaturedData []ccvtypes.VSCMaturedPacketData,
5 changes: 3 additions & 2 deletions x/ccv/provider/migrations/migrator.go
Original file line number Diff line number Diff line change
@@ -20,8 +20,9 @@ func NewMigrator(providerKeeper providerkeeper.Keeper, paramSpace paramtypes.Sub
}

// Migrating consensus version 1 to 2 is a no-op.
// <igrating from v1 -> v2 -> v3 will require multiple state breaking changes and migrations.
// First run provider@v2.x.y in production to migrate from v1 -> v2. Then use provider@v3.x.y to migrate from v2 -> v3.
// Migrating from v1 -> v2 -> v3 will require multiple state breaking changes and migrations.
// First run provider@v2.x.y in production to migrate from consensus version 1 to 2.
// Then, in order to migrate to consensus version 3, first upgrade to provider@v3.x.y.
func (m Migrator) Migrate1to2(ctx sdktypes.Context) error {
return nil
}
Loading