Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update migration handling for provider consensus v2->v3 #1536

Merged
merged 2 commits into from
Dec 21, 2023
Merged

chore: update migration handling for provider consensus v2->v3 #1536

merged 2 commits into from
Dec 21, 2023

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Dec 21, 2023 •
edited
Loading

Description

Closes: #1535

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@MSalopek MSalopek added the S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) label Dec 21, 2023
@MSalopek MSalopek self-assigned this Dec 21, 2023
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Dec 21, 2023
@MSalopek MSalopek marked this pull request as ready for review December 21, 2023 12:15
@MSalopek MSalopek requested a review from a team as a code owner December 21, 2023 12:15
@MSalopek MSalopek force-pushed the masa/1535-throttle-migration-refactor branch from acaa4ce to 7b504c4 Compare December 21, 2023 12:16
mpoke
mpoke approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See my comments below.

x/ccv/provider/migrations/migrator.go Outdated Show resolved Hide resolved
x/ccv/provider/migrations/migrator.go Outdated Show resolved Hide resolved
x/ccv/provider/keeper/throttle_legacy.go Outdated Show resolved Hide resolved
x/ccv/provider/keeper/throttle_legacy.go Show resolved Hide resolved
@MSalopek MSalopek added this pull request to the merge queue Dec 21, 2023
Merged via the queue into main with commit 4a69b93 Dec 21, 2023
17 checks passed
@MSalopek MSalopek deleted the masa/1535-throttle-migration-refactor branch December 21, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bermuell bermuell bermuell approved these changes

@mpoke mpoke mpoke approved these changes

Assignees

@MSalopek MSalopek

Labels
C:x/provider Assigned automatically by the PR labeler S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update provider throttle migrations; refactor migrations
3 participants
@MSalopek @mpoke @bermuell