feat: Add QueryAllPairsValConAddrByConsumerChainID
#1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Testing
ThanhNhann
changed the title
QueryAllPairsValConAddrByConsumerChainIDQueryAllPairsValConAddrByConsumerChainID
MSalopek
reviewed
Dec 13, 2023
MSalopek
reviewed
Dec 14, 2023
MSalopek
reviewed
Dec 19, 2023
MSalopek
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Please fix this typo:
https://github.com/cosmos/interchain-security/pull/1503/files#r1431241558
Co-authored-by: MSalopek <[email protected]>
|
Hi @MSalopek, I see we lack a lot of tests for queries, I think we should make a pr to solve this to cover this |
|
@ThanhNhann could you please add a changelog entry in the |
…ttps://github.com/decentrio/interchain-security into nhan/add_QueryAllPairsValConAddrByConsumerChainID
|
Updated it @mpoke, can you review and merge it? btw I think we should take a time to make the testing for our queries |
mpoke
reviewed
Jan 4, 2024
mpoke
reviewed
Jan 4, 2024
.changelog/unreleased/improvements/1503-query-key-assignment.md
Outdated
Show resolved
Hide resolved
21 tasks
…into nhan/add_QueryAllPairsValConAddrByConsumerChainID
mpoke
requested changes
Jan 5, 2024
sainoe
reviewed
Jan 5, 2024
| string provider_address = 1 [ (gogoproto.moretags) = "yaml:\"address\"" ]; | ||
| // The consensus address of the validator on the consumer chain | ||
| string consumer_address = 2 [ (gogoproto.moretags) = "yaml:\"address\"" ]; | ||
| tendermint.crypto.PublicKey consumer_key = 3; |
There was a problem hiding this comment.
Suggested change
| tendermint.crypto.PublicKey consumer_key = 3; | |
| // The public key of the validator on the consumer chain | |
| tendermint.crypto.PublicKey consumer_key = 3; |
mergify bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
* add QueryAllPairsValConAddrByConsumerChainID * Lint * add pubkey in PairValConAddrProviderAndConsumer struct * add test TestQueryAllPairsValConAddrByConsumerChainID * add doc * Update docs/docs/features/key-assignment.md Co-authored-by: MSalopek <[email protected]> * add changelog * update with Marius Poke's suggestions * update logic get data --------- Co-authored-by: Du Nguyen <[email protected]> Co-authored-by: MSalopek <[email protected]> (cherry picked from commit 56399f6) # Conflicts: # tests/e2e/tracehandler_testdata/slashThrottle.json
mpoke
pushed a commit
that referenced
this pull request
Jan 5, 2024
…#1551) feat: Add `QueryAllPairsValConAddrByConsumerChainID` (#1503) * add QueryAllPairsValConAddrByConsumerChainID * Lint * add pubkey in PairValConAddrProviderAndConsumer struct * add test TestQueryAllPairsValConAddrByConsumerChainID * add doc * Update docs/docs/features/key-assignment.md Co-authored-by: MSalopek <[email protected]> * add changelog * update with Marius Poke's suggestions * update logic get data --------- Co-authored-by: Du Nguyen <[email protected]> Co-authored-by: MSalopek <[email protected]> (cherry picked from commit 56399f6) # Conflicts: # tests/e2e/tracehandler_testdata/slashThrottle.json Co-authored-by: Nguyen Thanh Nhan | Decentrio <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1251
This PR adds
QueryAllPairsValConAddrByConsumerChainIDmethod to get list of all pairs valConsensus address byConsummer chainIDAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...