Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add query for getting all assigned keys #1546

Closed

Conversation

freak12techno
Copy link
Contributor

@freak12techno freak12techno commented Dec 28, 2023

Description

Closes: #984

Adds provider query to fetch all assigned keys (either all of them, or filtered by consumer chain ID).
This is quite an alpha version that was never tested yet, please treat it accordingly.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@freak12techno freak12techno requested a review from a team as a code owner December 28, 2023 22:50
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Dec 28, 2023
@freak12techno freak12techno force-pushed the add-query-for-assigned-keys branch from 4322232 to 3d3dbd4 Compare December 28, 2023 22:54
@freak12techno freak12techno marked this pull request as draft December 28, 2023 22:55
@mpoke
Copy link
Contributor

mpoke commented Jan 4, 2024

@freak12techno please note this similar PR #1503

@freak12techno
Copy link
Contributor Author

@mpoke whoops, didn't notice that one. Do you think it's worth having what I did then?

@mpoke
Copy link
Contributor

mpoke commented Jan 8, 2024

whoops, didn't notice that one. Do you think it's worth having what I did then?

@freak12techno Only if there is a use case that cannot be covered with the existing query.

@mpoke
Copy link
Contributor

mpoke commented Jan 10, 2024

@freak12techno #1503 was merged and it's part of ICS v3.3.0, which will end up on Gaia v15 (the next release on Gaia). Please let us know if that is sufficient to close #984 and the corresponding Gaia issue cosmos/gaia#2555.

@freak12techno
Copy link
Contributor Author

@mpoke I think that's sufficient, feel free to close

@mpoke mpoke closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a command to Gaia to retrieve all consumer chain keys for a specific consumer chain
2 participants