Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Integration of consumer versions v5.x with provider version v6.2.x is broken #2359

Closed
Tracked by #2382
bermuell opened this issue Oct 17, 2024 · 0 comments · Fixed by #2373
Closed
Tracked by #2382
Assignees
Labels
type: bug Issues that need priority attention -- something isn't working

Comments

@bermuell
Copy link
Contributor

bermuell commented Oct 17, 2024

What happened?

Genesis information exported from provider v6.x is not supported by older consumer versions e.g. v5.x
Starting a consumer chain with ccvconsumer content generated by provider v6.2.x fails:

panic: unknown field "consumer_id" in types.ConsumerParams

goroutine 1 [running]:
github.com/cosmos/cosmos-sdk/codec.(*ProtoCodec).MustUnmarshalJSON(0x0?, {0xc000d3d000?, 0x0?, 0x0?}, {0x38b7a68?, 0xc000b0d1e0?})
        /go/pkg/mod/github.com/cosmos/[email protected]/codec/proto_codec.go:219 +0x3b
github.com/cosmos/interchain-security/v5/x/ccv/consumer.AppModule.InitGenesis({{}, {{0xc000d7a5a0, 0x2f}, {0x38b0ab8, 0xc001cb8230}, {0x0, 0x0}, {0x38f4860, 0xc000e077e0}, {0x38b7b58, ...}, ...}, ...}, ...)
        /interchain-security/x/ccv/consumer/module.go:139 +0x94

Interchain Security Version

v6.2.0

How to reproduce?

Start consumer version 5.2.0 with genesis file extended with ccvconsumer information exported from provider version v6.2.0
ccvconsumer.params contains

   "params": {
        "enabled": true,
        "blocks_per_distribution_transmission": "1000",
        "distribution_transmission_channel": "",
        "provider_fee_pool_addr_str": "",
        "ccv_timeout_period": "2419200s",
        "transfer_timeout_period": "3600s",
        "consumer_redistribution_fraction": "0.75",
        "historical_entries": "10000",
        "unbonding_period": "1209600s",
        "soft_opt_out_threshold": "0",
        "reward_denoms": [],
        "provider_reward_denoms": [],
        "retry_delay_period": "3600s",
        "consumer_id": "0"
      },
@bermuell bermuell added status: waiting-triage This issue/PR has not yet been triaged by the team. type: bug Issues that need priority attention -- something isn't working labels Oct 17, 2024
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Oct 17, 2024
@bermuell bermuell self-assigned this Oct 17, 2024
@bermuell bermuell moved this from 🩹 F1: Triage to 🏗 F3: InProgress in Cosmos Hub Oct 17, 2024
@bermuell bermuell removed the status: waiting-triage This issue/PR has not yet been triaged by the team. label Oct 17, 2024
@bermuell bermuell moved this from 🏗 F3: InProgress to 👀 F3: InReview in Cosmos Hub Oct 30, 2024
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Nov 6, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues that need priority attention -- something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant