Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added suppport for version specific actions e2e test #2319

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Sep 30, 2024

Description

Closes: #2198

Refactoring of tests to support execution of tests against target versions (provider, consumer) where execution
of action differs.

  • Added action handler and commands for v5
  • fixed issue when running tests in parallel

tested with compatibility tests on versions v5.2.0 (consumer/provider) v6.1.0 (consumer/provider)
compatibility of consumer v5.x with provider version v6.2.x is broken (issue #2359)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@bermuell bermuell self-assigned this Sep 30, 2024
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler labels Sep 30, 2024
@bermuell bermuell force-pushed the bernd/2198-e2e-test branch 2 times, most recently from 4e7773b to 9cae0fa Compare October 1, 2024 07:28
@bermuell bermuell force-pushed the bernd/2198-e2e-test branch from 9cae0fa to 8388dd4 Compare October 16, 2024 15:05
@bermuell bermuell force-pushed the bernd/2198-e2e-test branch from 8388dd4 to c59766e Compare October 17, 2024 08:52
@bermuell bermuell marked this pull request as ready for review October 17, 2024 08:55
@bermuell bermuell requested a review from a team as a code owner October 17, 2024 08:55
@bermuell bermuell requested a review from stana-miric October 18, 2024 07:36
tests/e2e/actions.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@stana-miric stana-miric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bermuell bermuell enabled auto-merge October 22, 2024 20:33
@bermuell bermuell disabled auto-merge October 22, 2024 20:34
@bermuell bermuell requested a review from mpoke November 5, 2024 07:54
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin approval.

Please resolve conflicts.

@bermuell bermuell added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 6db885c Nov 7, 2024
19 checks passed
@bermuell bermuell deleted the bernd/2198-e2e-test branch November 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CI Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e tests: support version specific actions for compatbility tests
3 participants