Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable consumer chains to send ICS rewards in non-native denoms #1634

Closed
Tracked by #853
sainoe opened this issue Feb 9, 2024 · 0 comments · Fixed by #2290
Closed
Tracked by #853

Enable consumer chains to send ICS rewards in non-native denoms #1634

sainoe opened this issue Feb 9, 2024 · 0 comments · Fixed by #2290
Labels
scope: provider Issues related to the provider chain type: feature-request New feature or request improvement

Comments

@sainoe
Copy link
Contributor

sainoe commented Feb 9, 2024

Problem description:

In the PSS reward distribution logic, consumer chains are identified from the IBC path used to send rewards. It allows tracking the rewards received for each consumer chain and allocating them to opted-in validators.

This causes a problem if, for instance, Stride wants to send native Noble USDCs as rewards to the HUB, because it requires unwinding the denom by sending it through Noble. In this scenario, rewards will be allocated to Noble instead of Stride.

For more context, see this comment.

Potential solution

An alternative would be to use the memo or any other field that the sending chain can write to identify the source, which would be durable when passed through Noble's PFM.

PFM code ref

Solving Criteria

Ensure the rewards are allocated to the sender consumer chain

Note: keep in mind backward compatibility while changing the consumer logic

@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Feb 9, 2024
@github-actions github-actions bot added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Feb 9, 2024
@sainoe sainoe moved this from 🩹 F1: Triage to 🤔 F1: Investigate in Cosmos Hub Feb 27, 2024
@mpoke mpoke moved this from 🤔 F1: Investigate to 📥 F2: Todo in Cosmos Hub Sep 17, 2024
@mpoke mpoke added type: feature-request New feature or request improvement scope: provider Issues related to the provider chain and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Sep 17, 2024
@mpoke mpoke changed the title Partial Set Security: investigate the PFM issue for the reward distribution Enable consumer chains to send ICS rewards in non-native denoms Sep 17, 2024
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Sep 27, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: provider Issues related to the provider chain type: feature-request New feature or request improvement
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants