Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic]: Refactor ICS reward distribution to address several issues #2286

Closed
8 tasks done
mpoke opened this issue Sep 19, 2024 · 0 comments
Closed
8 tasks done

[Epic]: Refactor ICS reward distribution to address several issues #2286

mpoke opened this issue Sep 19, 2024 · 0 comments
Labels
admin: epic An EPIC -- meta issue used to track a body of work type: bug Issues that need priority attention -- something isn't working

Comments

@mpoke
Copy link
Contributor

mpoke commented Sep 19, 2024

Problem

The refactoring is needed to address several issues.

  • Consumer chains with the canonical transfer channel to the provider on a different client than the CCV channel will not be able to distribute rewards to provider validators. This is due to this check. Note that this was not a problem before ICS v6.0.0.
  • Consumer chains cannot send rewards in non-native denoms. For more details, see Enable consumer chains to send ICS rewards in non-native denoms #1634.
  • Although consumer chain creation is permissionless, consumers still need to go through governance to whitelist their native denoms to be allowed as ICS rewards.
  • New consumer chains (that don't have a transfer channel to the provider before joining ICS) cannot whitelist their denoms for ICS rewards as the name of the transfer channel endpoint on the provider side is not yet known. This means that opted in validators will not receive rewards in the first weeks after launching the consumer until the gov prop whitelisting the denom passes. Moreover, once the gov prop passes, those rewards are not retroactively distributed and they remain in the provider module account.

Closing criteria

All the tasks below are completed.

Task list

Identifying the source of ICS rewards

Preview Give feedback

Permissionless denom allowlisting

Preview Give feedback

Fix existing state

Preview Give feedback

Other issues

Preview Give feedback
  1. scope: provider source: codereview type: bug
    sainoe
@mpoke mpoke added admin: epic An EPIC -- meta issue used to track a body of work type: bug Issues that need priority attention -- something isn't working labels Sep 19, 2024
@mpoke mpoke added this to Cosmos Hub Sep 19, 2024
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Sep 19, 2024
@mpoke mpoke moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Sep 19, 2024
@mpoke mpoke moved this from 📥 F2: Todo to 🏗 F3: InProgress in Cosmos Hub Oct 3, 2024
@mpoke mpoke moved this from 🏗 F3: InProgress to ✅ Done in Cosmos Hub Oct 14, 2024
@mpoke mpoke closed this as completed Oct 14, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 👍 F4: Assessment in Cosmos Hub Oct 14, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin: epic An EPIC -- meta issue used to track a body of work type: bug Issues that need priority attention -- something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant