Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ledger signing on macOS #2763

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

jhernandezb
Copy link
Contributor

Description

Closes: #XXXX

Newest versions of macOS and Xcode seems to have moved a few things and signing with ledger through the binary will not work with them.

This PR bumps hid and ledger-cosmos deps that include the fix.

See:
Zondax/hid#15
cosmos/ledger-cosmos#101


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@jhernandezb jhernandezb force-pushed the jhernandezb/fix-ledger-macos branch from c1c5caf to 11c731c Compare October 16, 2023 17:29
@Galadrin
Copy link

Got signature issue on Linux and solved my issue with this fix as well

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Approve!

@mpoke mpoke merged commit b11af5a into cosmos:main Nov 1, 2023
17 checks passed
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
p-offtermatt pushed a commit that referenced this pull request Nov 1, 2023
(cherry picked from commit b11af5a)

Co-authored-by: Jorge Hernandez <[email protected]>
@mpoke mpoke mentioned this pull request Nov 7, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants