Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ledger dependency #335

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

mnguyen-io
Copy link
Contributor

Implementation details

Fixes Ledger signing problems on by updating to newer versions of hid, ledger-go and ledger-cosmos-go.

Older versions result in an empty Error: message when attempting to sign transactions with a Ledger and bandd binary.

Same issue is described (and same fix merged) to Cosmos Gaia repo: cosmos/gaia#2763

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@taobun taobun merged commit b88da6f into bandprotocol:master Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants