Use local read receipts for notifications #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staab
reviewed
Dec 11, 2024
ticruz38
force-pushed
the
fix/notifications
branch
from
f080ffb to
3cbe593
Compare
staab
reviewed
Dec 13, 2024
There was a problem hiding this comment.
- Various
SEEN_events are still being fetched and decrypted, we can remove all of that. - The subscriptions on the notifications pages aren't doing anything any more.
- Record "mark all as seen" explicitly to avoid getting re-notified about old stuff. You'll need to check that when getting notifications for channels, which means you need to know which notification keys correspond to channels. So a different naming scheme than channel id might be needed.
| onMount(() => { | ||
| const tracked = new Set() | ||
| setChecked(["replies", "mentions"]) | ||
|
|
||
| const unsub = unreadMainNotifications.subscribe(async events => { |
src/app/views/ChannelsList.svelte
Outdated
| @@ -39,6 +39,8 @@ | |||
| } | |||
| }) | |||
|
|
|||
| const markAllChannelsRead = () => setChecked($channels.map(c => c.id)) | |||
There was a problem hiding this comment.
Let's do something here like channels/*, since old events frequently come in after marking all as read, resetting the notification bell. This is a flaw of the current approach.
ticruz38
force-pushed
the
fix/notifications
branch
from
f5eb56e to
f23715e
Compare
|
|
This can still be simplified a decent amount I think:
|
|
applied your suggestions, path based seen check Notifications are now under notes/* or reactions/, everything related to messages is under channels/, "*" is used for login and signup and is a fallback for any subpath no checked yet. |
- move notifications.ts to /engine/
- removed unused notification's subscriptions
ticruz38
force-pushed
the
fix/notifications
branch
from
213aed1 to
4564f0a
Compare
staab
pushed a commit
that referenced
this pull request
Dec 17, 2024
* local read receipts for notifications * local read receipts for channels * - fix read notification infinite loop - move notifications.ts to /engine/ * clean notifications import * - specific notifications prefix for channels - removed unused notification's subscriptions * path based seen check
staab
pushed a commit
that referenced
this pull request
Dec 30, 2024
* local read receipts for notifications * local read receipts for channels * - fix read notification infinite loop - move notifications.ts to /engine/ * clean notifications import * - specific notifications prefix for channels - removed unused notification's subscriptions * path based seen check
staab
pushed a commit
that referenced
this pull request
Jan 15, 2025
* local read receipts for notifications * local read receipts for channels * - fix read notification infinite loop - move notifications.ts to /engine/ * clean notifications import * - specific notifications prefix for channels - removed unused notification's subscriptions * path based seen check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#500
Use a local store for read receipts, inspired by flotilla.