- fix read notification infinite loop

- move notifications.ts to /engine/

src/app/MenuDesktop.svelte

@@ -24,7 +24,7 @@
   import {slowConnections} from "src/app/state"
   import {router} from "src/app/util/router"
   import {env, hasNewMessages} from "src/engine"
-  import {hasNewNotifications} from "src/domain/notifications"
+  import {hasNewNotifications} from "src/engine/notifications"
 
   const {page} = router
 

src/app/MenuMobile.svelte

@@ -10,7 +10,7 @@
   import {slowConnections, menuIsOpen} from "src/app/state"
   import {router} from "src/app/util/router"
   import {env, hasNewMessages} from "src/engine"
-  import {hasNewNotifications} from "src/domain/notifications"
+  import {hasNewNotifications} from "src/engine/notifications"
 
   const closeSubMenu = () => {
     subMenu = null

src/app/Nav.svelte

@@ -9,7 +9,7 @@
   import {menuIsOpen, searchTerm} from "src/app/state"
   import {router} from "src/app/util/router"
   import {hasNewMessages} from "src/engine"
-  import {hasNewNotifications} from "src/domain/notifications"
+  import {hasNewNotifications} from "src/engine/notifications"
 
   let innerWidth = 0
   let searching = false

src/app/views/ChannelsDetail.svelte

@@ -12,7 +12,7 @@
   import {router} from "src/app/util/router"
   import {markChannelRead, getChannelIdFromEvent, listenForMessages} from "src/engine"
   import Popover from "src/partials/Popover.svelte"
-  import {setChecked} from "src/domain/notifications"
+  import {setChecked} from "src/engine/notifications"
 
   export let pubkeys
   export let channelId

src/app/views/ChannelsList.svelte

@@ -12,7 +12,7 @@
   import ChannelsListItem from "src/app/views/ChannelsListItem.svelte"
   import {router} from "src/app/util/router"
   import {channels, hasNewMessages} from "src/engine"
-  import {setChecked} from "src/domain/notifications"
+  import {setChecked} from "src/engine/notifications"
 
   const activeTab = window.location.pathname.slice(1) === "channels" ? "conversations" : "requests"
   const setActiveTab = tab => {

src/app/views/NotificationSectionMain.svelte

@@ -7,7 +7,7 @@
   import NotificationList from "src/app/views/NotificationList.svelte"
   import NotificationMention from "src/app/views/NotificationMention.svelte"
   import NotificationReplies from "src/app/views/NotificationReplies.svelte"
-  import {mainNotifications, setChecked, unreadMainNotifications} from "src/domain/notifications"
+  import {mainNotifications, setChecked, unreadMainNotifications} from "src/engine/notifications"
 
   export let limit
 
@@ -45,12 +45,13 @@
         for (const id of untracked) {
           tracked.add(id)
         }
-
-        setChecked(["replies", "mentions"])
       }
     })
 
-    return unsub
+    return () => {
+      unsub()
+      setChecked(["replies", "mentions"])
+    }
   })
 </script>
 

src/app/views/NotificationSectionReactions.svelte

@@ -11,7 +11,7 @@
     reactionNotifications,
     setChecked,
     unreadReactionNotifications,
-  } from "src/domain/notifications"
+  } from "src/engine/notifications"
 
   export let limit
 
@@ -47,12 +47,13 @@
         for (const id of untracked) {
           tracked.add(id)
         }
-
-        setChecked(["reactions", "zaps"])
       }
     })
 
-    return unsub
+    return () => {
+      unsub()
+      setChecked(["reactions", "zaps"])
+    }
   })
 </script>
 

src/app/views/Notifications.svelte

@@ -7,7 +7,7 @@
   import NotificationSectionReactions from "src/app/views/NotificationSectionReactions.svelte"
   import {router} from "src/app/util/router"
   import {sessionWithMeta, loadNotifications} from "src/engine"
-  import {unreadMainNotifications, unreadReactionNotifications} from "src/domain/notifications"
+  import {unreadMainNotifications, unreadReactionNotifications} from "src/engine/notifications"
 
   const allTabs = ["Mentions & Replies", "Reactions"]
 

src/app/views/Onboarding.svelte

@@ -19,7 +19,7 @@
     broadcastUserData,
   } from "src/engine"
   import {router} from "src/app/util/router"
-  import {setChecked} from "src/domain/notifications"
+  import {setChecked} from "src/engine/notifications"
 
   export let stage = "intro"
   export let invite = null

src/engine/state.ts

@@ -50,6 +50,7 @@ import {
   take,
   uniq,
   uniqBy,
+  max,
 } from "@welshman/lib"
 import type {Connection, PublishRequest, Target} from "@welshman/net"
 import {
@@ -376,7 +377,7 @@ export const deriveChecked = (key: string) => derived(checked, prop(key))
 export const getSeenAt = derived([checked], ([$checked]) => (key: string, event: TrustedEvent) => {
   const match = $checked[key]
   const fallback = $checked["*"]
-  const ts = Math.max(match || 0, fallback || 0)
+  const ts = max([match, fallback])
 
   if (ts >= event.created_at) return ts