Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move JSONFormatToInvalidSignatureError to an unconditionally-included file #2632

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move JSONFormatToInvalidSignatureError to an unconditionally-included file #2632

wants to merge 1 commit into from

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Nov 12, 2024

otherwise:

% go build -tags ' containers_image_fulcio_stub containers_image_rekor_stub' ./...
# github.com/containers/image/v5/signature/internal
signature/internal/sigstore_payload.go:83:9: undefined: JSONFormatToInvalidSignatureError

@mtrmac mtrmac mentioned this pull request Nov 12, 2024
Merged
@mtrmac mtrmac force-pushed the stubs-broken branch 3 times, most recently from 503fcda to e5e9c24 Compare November 21, 2024 20:07
@mtrmac mtrmac force-pushed the stubs-broken branch 5 times, most recently from 204ca8b to 63679c9 Compare November 29, 2024 00:15
@mtrmac
Move JSONFormatToInvalidSignatureError to an unconditionally-included…
78b8ca7 
… file

otherwise:
> % go build -tags ' containers_image_fulcio_stub containers_image_rekor_stub' ./...
> # github.com/containers/image/v5/signature/internal
> signature/internal/sigstore_payload.go:83:9: undefined: JSONFormatToInvalidSignatureError

Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtrmac