Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stubs to match signature of actual methods #2541

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

SpangleLabs
Copy link
Contributor

#2526 has broken building v5.32.2 with the containers_image_fulcio_stub and containers_image_rekor_stub build tags, as the signatures for verifyRekorFulcio() and VerifyRekorSET() were updated without updating the corresponding stubs.

This PR updates the stubs to match

@mtrmac
Copy link
Collaborator

mtrmac commented Aug 27, 2024

Thanks!

First, https://github.com/containers/image/blob/main/CONTRIBUTING.md#sign-your-prs please, we can’t really even look at contributions with unclear copyright status.

@SpangleLabs SpangleLabs force-pushed the patch-1 branch 3 times, most recently from 60a2ff3 to e6ba63d Compare November 6, 2024 23:57
@SpangleLabs
Copy link
Contributor Author

SpangleLabs commented Nov 6, 2024

So sorry I missed this and then got pulled away to other things and forgot to update it!
I have updated the commit message now, (and rebased) sorry, and thank you! ^_^

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I’m afraid we broke that build another way since…

@mtrmac mtrmac merged commit 8a7f0b1 into containers:main Nov 12, 2024
10 checks passed
@mtrmac
Copy link
Collaborator

mtrmac commented Nov 12, 2024

I’m afraid we broke that build another way since…

#2632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants