Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare PHPStan #165

Merged
merged 27 commits into from
Jan 17, 2024
Merged

Prepare PHPStan #165

merged 27 commits into from
Jan 17, 2024

Conversation

szepeviktor
Copy link
Collaborator

@szepeviktor szepeviktor commented Oct 15, 2023

Resolving all I can.

@szepeviktor szepeviktor marked this pull request as ready for review October 25, 2023 13:28
@szepeviktor szepeviktor marked this pull request as draft October 25, 2023 13:29
@szepeviktor szepeviktor requested a review from iamgergo October 25, 2023 14:09
@szepeviktor szepeviktor marked this pull request as ready for review October 25, 2023 14:09
src/Fields/Slug.php Outdated Show resolved Hide resolved
@szepeviktor
Copy link
Collaborator Author

szepeviktor commented Oct 25, 2023

@iamgergo MediaController could throw an UnknownHttpMethod exception.


What would you take from these results?

Could you add a Root-compatible User class to tests/phpstan/?

@iamgergo iamgergo merged commit cd61916 into master Jan 17, 2024
19 checks passed
@szepeviktor szepeviktor deleted the prepare-phpstan branch January 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants