Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unknown HTTP method in MediaController #167

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Handle unknown HTTP method in MediaController #167

merged 3 commits into from
Oct 27, 2023

Conversation

szepeviktor
Copy link
Collaborator

@szepeviktor szepeviktor commented Oct 26, 2023 •
edited
Loading

This is not complete but a base to start with.

From #165 (comment)

@szepeviktor szepeviktor requested a review from iamgergo October 26, 2023 15:31
@iamgergo
Copy link
Member

So, in the routes file only these 3 methods are allowed. But you're right, it's a good idea to have a fallback. Can you import the class please?

@szepeviktor
Copy link
Collaborator Author

it's a good idea

It comes from phpstan.

@szepeviktor
Copy link
Collaborator Author

szepeviktor commented Oct 26, 2023 •
edited
Loading

Can you import the class please?

Done.
(I use FQCN in exceptions)

@szepeviktor
Copy link
Collaborator Author

Wait!
https://github.com/symfony/symfony/blob/3d078d158b895b10a9525bc56efd46715649491e/src/Symfony/Component/ErrorHandler/Tests/Exception/FlattenExceptionTest.php#L64

@iamgergo iamgergo merged commit 44e1491 into master Oct 27, 2023
18 of 20 checks passed
@iamgergo iamgergo deleted the szepeviktor-patch-3 branch October 27, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamgergo iamgergo Awaiting requested review from iamgergo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @iamgergo