Reparent out of grid #6264
Merged
Reparent out of grid #6264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruggi
commented
Aug 27, 2024
| show: 'visible-only-while-active', | ||
| }), | ||
| ], | ||
| controlsToRender: controlsForAbsoluteReparent(reparentTarget), |
There was a problem hiding this comment.
no logic changes here, just factored out the controls and the apply logic
ruggi
commented
Aug 27, 2024
| priority: 'bottom', | ||
| }, | ||
| ], | ||
| controlsToRender: controlsForGridReparent(reparentTarget), |
There was a problem hiding this comment.
no logic changes, just factored out the controls and the apply logic
ruggi
commented
Aug 27, 2024
| show: 'visible-only-while-active', | ||
| }), | ||
| ], | ||
| controlsToRender: controlsForStaticReparent(reparentTarget), |
There was a problem hiding this comment.
no logic changes, just factored out the controls
#13955 Bundle Size — 62.51MiB (~+0.01%).05cfeea(current) vs 916e8b9 master#13941(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13955 |
Baseline #13941 |
|
|---|---|---|
 Initial JS |
45.64MiB(~+0.01%) |
45.63MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.54% |
21.51% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4375 |
4375 |
| Duplicate Modules |
519 |
519 |
| Duplicate Code |
31.64% |
31.64% |
| Packages |
472 |
472 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13955 |
Baseline #13941 |
|
|---|---|---|
| JS |
62.5MiB (~+0.01%) |
62.49MiB |
| HTML |
11.05KiB (-0.33%) |
11.09KiB |
Bundle analysis report Branch feat/reparent-out-of-grid Project dashboard
Generated by RelativeCI Documentation Report issue
gbalint
reviewed
Aug 27, 2024
| updateSelectedViews('always', newPaths), | ||
| setCursorCommand(CSSCursor.Reparent), | ||
| showGridControls('mid-interaction', reparentTarget.newParent.intendedParentPath), | ||
| ], |
There was a problem hiding this comment.
I think a setElementsToRerender command is missing from here
There was a problem hiding this comment.
it was removed on purpose in #6258 because it doesn't look right with the grid placement
gbalint
reviewed
Aug 27, 2024
editor/src/components/canvas/canvas-strategies/strategies/grid-rearrange-move-strategy.ts
Show resolved
Hide resolved
bkrmendy
approved these changes
Aug 27, 2024
balazsbajorics
approved these changes
Aug 27, 2024
seanparsons
reviewed
Aug 27, 2024
editor/src/components/canvas/canvas-strategies/strategies/grid-rearrange-move-strategy.ts
Outdated
Show resolved
Hide resolved
seanparsons
approved these changes
Aug 27, 2024
gbalint
approved these changes
Aug 27, 2024
Merged
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** It's currently not possible to reparent out of a grid. **Fix:** Allow reparenting out of a grid while holding `cmd`, like all other reparenting scenarios. https://github.com/user-attachments/assets/df75b0ee-5098-4cba-b66c-507697cf03c0 **Notes:** The grid rearrange strategy now needs to act as a sort of meta strat, because 1) it needs a custom mouse drag handling (due to the grid placeholder controls) and 2) cells don't have positioning props so absolute reparenting needs some massaging in order to work Fixes #6263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
It's currently not possible to reparent out of a grid.
Fix:
Allow reparenting out of a grid while holding
cmd, like all other reparenting scenarios.Kapture.2024-08-27.at.13.21.53.mp4
Notes:
The grid rearrange strategy now needs to act as a sort of meta strat, because 1) it needs a custom mouse drag handling (due to the grid placeholder controls) and 2) cells don't have positioning props so absolute reparenting needs some massaging in order to work
Fixes #6263