Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test grid reparenting #6269

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Test grid reparenting #6269

merged 3 commits into from
Aug 28, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Aug 28, 2024

This is a followup to #6264 and #6258 , adding automated tests for reparenting strategies concerning grids.

Fixes #6268

@ruggi ruggi marked this pull request as draft August 28, 2024 13:02
Copy link
Contributor

github-actions bot commented Aug 28, 2024

Try me

Copy link

relativeci bot commented Aug 28, 2024

#13974 Bundle Size — 62.54MiB (+0.05%).

bcc441c(current) vs 916e8b9 master#13968(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression
                 Current
#13974
     Baseline
#13968
Regression  Initial JS 45.67MiB(+0.06%) 45.64MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 22.91% 21.53%
No change  Chunks 30 30
No change  Assets 33 33
Change  Modules 4377(+0.05%) 4375
No change  Duplicate Modules 519 519
Change  Duplicate Code 31.63%(-0.03%) 31.64%
No change  Packages 472 472
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13974
     Baseline
#13968
Regression  JS 62.52MiB (+0.05%) 62.5MiB
Improvement  HTML 11.05KiB (-0.33%) 11.09KiB

Bundle analysis reportBranch feat/test-grid-reparentProject dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi ruggi marked this pull request as ready for review August 28, 2024 13:23
@ruggi ruggi merged commit f2a2337 into master Aug 28, 2024
16 checks passed
@ruggi ruggi deleted the feat/test-grid-reparent branch August 28, 2024 15:06
liady pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test grid reparenting
3 participants