Special size measurements for CSS grid properties #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13219 Bundle Size — 62.38MiB (+0.02%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13219 |
Baseline #13218 |
|
|---|---|---|
 Initial JS |
45.44MiB(+0.02%) |
45.43MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
22.74% |
21.56% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4312(-0.02%) |
4313 |
 Duplicate Modules |
524(-0.19%) |
525 |
| Duplicate Code |
31.78%(-0.03%) |
31.79% |
| Packages |
450 |
450 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 1 improvement
| Current #13219 |
Baseline #13218 |
|
|---|---|---|
| JS |
62.37MiB (+0.02%) |
62.35MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch feature/grid-special-size-measur... Project dashboard
bkrmendy
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics and
liady
seanparsons
approved these changes
Jul 1, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
Split out from #6027 ## Description This PR adds the `specialSizeMeasurements` fields we need to support the grid strategies from #6027. This PR doesn't add tests (beyond the snapshots), because this functionality will be tested through the strategies **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #6027
Description
This PR adds the
specialSizeMeasurementsfields we need to support the grid strategies from #6027.This PR doesn't add tests (beyond the snapshots), because this functionality will be tested through the strategies
Manual Tests:
I hereby swear that: