Skip to content

Commit

Permalink
Special size measurements for CSS grid properties (#6029)
Browse files Browse the repository at this point in the history
Split out from #6027

## Description
This PR adds the `specialSizeMeasurements` fields we need to support the
grid strategies from
#6027.

This PR doesn't add tests (beyond the snapshots), because this
functionality will be tested through the strategies

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Preview mode
  • Loading branch information
bkrmendy authored Jul 1, 2024
1 parent 6a26bbc commit c431313
Show file tree
Hide file tree
Showing 7 changed files with 6,868 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,32 @@ Object {
"height": null,
"width": null,
},
"containerGridProperties": Object {
"gridAutoColumns": null,
"gridAutoRows": null,
"gridTemplateColumns": null,
"gridTemplateRows": null,
},
"containerGridPropertiesFromProps": Object {
"gridAutoColumns": null,
"gridAutoRows": null,
"gridTemplateColumns": null,
"gridTemplateRows": null,
},
"coordinateSystemBounds": null,
"display": "initial",
"elementGridProperties": Object {
"gridColumnEnd": null,
"gridColumnStart": null,
"gridRowEnd": null,
"gridRowStart": null,
},
"elementGridPropertiesFromProps": Object {
"gridColumnEnd": null,
"gridColumnStart": null,
"gridRowEnd": null,
"gridRowStart": null,
},
"flexDirection": null,
"float": "none",
"fontSize": null,
Expand Down Expand Up @@ -290,8 +314,32 @@ Object {
"height": null,
"width": null,
},
"containerGridProperties": Object {
"gridAutoColumns": null,
"gridAutoRows": null,
"gridTemplateColumns": null,
"gridTemplateRows": null,
},
"containerGridPropertiesFromProps": Object {
"gridAutoColumns": null,
"gridAutoRows": null,
"gridTemplateColumns": null,
"gridTemplateRows": null,
},
"coordinateSystemBounds": null,
"display": "initial",
"elementGridProperties": Object {
"gridColumnEnd": null,
"gridColumnStart": null,
"gridRowEnd": null,
"gridRowStart": null,
},
"elementGridPropertiesFromProps": Object {
"gridColumnEnd": null,
"gridColumnStart": null,
"gridRowEnd": null,
"gridRowStart": null,
},
"flexDirection": null,
"float": "none",
"fontSize": null,
Expand Down
Loading

0 comments on commit c431313

Please sign in to comment.