Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix: soft-delete / restore projects #4874

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Feb 12, 2024

Fix #4873

Problem:

The Remix app needs a way to (soft-)delete and restore projects via the projects page.

Fix:

  1. Since our database already has a (unused?) deleted column for projects, this PR makes use of it.
  2. Added a new route to soft-delete projects which will mark a given project as deleted: true. It only works for non-deleted projects.
  3. Added a new route to restore soft-deleted projects, which will mark a given project as deleted: null. It only works for soft-deleted projects.
  4. Added unit and integration tests.
  5. Updated the existing tests and logic for updating and listing projects so that they only target non-deleted projects.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Try me

Copy link

relativeci bot commented Feb 12, 2024

Job #10374: Bundle Size — 61.73MiB (~-0.01%).

636223b(current) vs d299c8d master#10372(baseline)

Warning

Bundle contains 57 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10374
     Baseline
Job #10372
Regression  Initial JS 34.77MiB(~+0.01%) 34.77MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.46% 85.16%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4294 4294
No change  Duplicate Modules 493 493
No change  Duplicate Code 31.01% 31.01%
No change  Packages 455 455
No change  Duplicate Packages 57 57
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10374
     Baseline
Job #10372
Regression  JS 61.72MiB (~+0.01%) 61.72MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10374 reportView feat/remix-delete-project branch activityView project dashboard

Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit 5c0a42d into master Feb 12, 2024
18 checks passed
@ruggi ruggi deleted the feat/remix-delete-project branch February 12, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soft-delete and restore projects on Remix
4 participants