Remix: hard-delete projects #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #10388: Bundle Size — 61.73MiB (~-0.01%).
Warning Bundle contains 57 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10388 report View feat/remix-destroy-projects branch activity View project dashboard |
liady
approved these changes
Feb 12, 2024
|
Performance test results: |
Rheeseyb
reviewed
Feb 12, 2024
|
|
||
| await fn() | ||
| const got = await prisma.project.findMany({ where: { owner_id: 'bob' } }) | ||
| expect(got.map((p) => p.proj_id)).toEqual(['one', 'four', 'five']) |
There was a problem hiding this comment.
Can you add an expect for the projects that aren't owned by 'bob' please to ensure we haven't accidentally deleted anyone else's projects (soft deleted or otherwise)
There was a problem hiding this comment.
that's already ensure here
but I can add it here too
Rheeseyb
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4880
Problem:
#4874 introduced soft-deleted projects that will end up in a
Trashor similar concept. Now, we also need a way to destroy (= hard delete) projects as well.Fix:
Empty the trashconcept.Note: it's easy to see a future case of soft/hard-deleting a selection of projects, but we can add it later on as a simple incremental change rather than over-engineering now.