Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show grid lines when the grid is selected or when child interaction is active #6645

Closed
ruggi opened this issue Nov 15, 2024 · 0 comments · Fixed by #6647
Closed

Only show grid lines when the grid is selected or when child interaction is active #6645

ruggi opened this issue Nov 15, 2024 · 0 comments · Fixed by #6647
Assignees

Comments

@ruggi
Copy link
Contributor

ruggi commented Nov 15, 2024

No description provided.

@ruggi ruggi self-assigned this Nov 15, 2024
ruggi added a commit that referenced this issue Nov 18, 2024
…6647)

**Problem:**

Grid lines are shown all the time whether a grid or a grid child is
selected. The grid sizing pills are also shown all the time.

**Fix:**

Only show the grid lines if:
- the grid itself is selected
- a grid child is selected **and** an interaction is in progress

Only show the grid sizing pills if:
- the grid itself is selected

**Note:** I enabled the grid lines also for absolute resize of grid
children because they can be affected by the grid so I thought it would
be good to have them, but lmk if you feel otherwise.


https://github.com/user-attachments/assets/eba83673-fe5d-43a2-8dcf-aba7bcc2cca1



Fixes #6645
liady pushed a commit that referenced this issue Dec 13, 2024
…6647)

**Problem:**

Grid lines are shown all the time whether a grid or a grid child is
selected. The grid sizing pills are also shown all the time.

**Fix:**

Only show the grid lines if:
- the grid itself is selected
- a grid child is selected **and** an interaction is in progress

Only show the grid sizing pills if:
- the grid itself is selected

**Note:** I enabled the grid lines also for absolute resize of grid
children because they can be affected by the grid so I thought it would
be good to have them, but lmk if you feel otherwise.


https://github.com/user-attachments/assets/eba83673-fe5d-43a2-8dcf-aba7bcc2cca1



Fixes #6645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant