Only show grid lines when selecting grid or during child interaction #6647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15168 Bundle Size — 58.08MiB (~+0.01%).842ec48(current) vs d1d46c1 master#15167(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15168 |
Baseline #15167 |
|
|---|---|---|
 Initial JS |
41.06MiB(~+0.01%) |
41.06MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.14% |
18.02% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4169 |
4169 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.29% |
27.29% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15168 |
Baseline #15167 |
|
|---|---|---|
| JS |
58.08MiB (~+0.01%) |
58.08MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feat/grid-lines-during-interacti... Project dashboard
Generated by RelativeCI Documentation Report issue
seanparsons
reviewed
Nov 15, 2024
|
please hide the track size pills too! 
|
seanparsons
approved these changes
Nov 15, 2024
@balazsbajorics fixed ✅ |
gbalint
reviewed
Nov 15, 2024
# Conflicts: # editor/src/components/canvas/canvas-strategies/strategies/grid-element-change-location-strategy.spec.browser2.tsx # editor/src/components/canvas/controls/grid-controls.tsx
gbalint
approved these changes
Nov 18, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
…6647) **Problem:** Grid lines are shown all the time whether a grid or a grid child is selected. The grid sizing pills are also shown all the time. **Fix:** Only show the grid lines if: - the grid itself is selected - a grid child is selected **and** an interaction is in progress Only show the grid sizing pills if: - the grid itself is selected **Note:** I enabled the grid lines also for absolute resize of grid children because they can be affected by the grid so I thought it would be good to have them, but lmk if you feel otherwise. https://github.com/user-attachments/assets/eba83673-fe5d-43a2-8dcf-aba7bcc2cca1 Fixes #6645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Grid lines are shown all the time whether a grid or a grid child is selected. The grid sizing pills are also shown all the time.
Fix:
Only show the grid lines if:
Only show the grid sizing pills if:
Note: I enabled the grid lines also for absolute resize of grid children because they can be affected by the grid so I thought it would be good to have them, but lmk if you feel otherwise.
Screen.Recording.2024-11-18.at.11.38.09.mov
Fixes #6645