Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show grid lines when selecting grid or during child interaction #6646

Closed
wants to merge 1 commit into from

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Nov 15, 2024

Problem:

Grid lines are shown all the time whether a grid or a grid child is selected.

Fix:

Only show the grid lines if:

  • the grid itself is selected
  • a grid child is selected and an interaction is in progress

Note: I enabled the grid lines also for absolute resize of grid children because they can be affected by the grid so I thought it would be good to have them, but lmk if you feel otherwise.

Screen.Recording.2024-11-15.at.11.14.01.mov

Fixes #6645

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Try me

Copy link

relativeci bot commented Nov 15, 2024

#15148 Bundle Size — 58.08MiB (~+0.01%).

6a1bc2c(current) vs d1d46c1 master#15141(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#15148
     Baseline
#15141
Regression  Initial JS 41.05MiB(~+0.01%) 41.05MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.13% 18.02%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4169 4169
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.3% 27.3%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#15148
     Baseline
#15141
Regression  JS 58.07MiB (~+0.01%) 58.07MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch feat/grid-placeholders-during-in...Project dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi ruggi closed this Nov 15, 2024
@ruggi ruggi deleted the feat/grid-placeholders-during-interaction branch November 15, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show grid lines when the grid is selected or when child interaction is active
2 participants