-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several issues with Datatables #3750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-several-issues-with-tables-update
Kudos to James for having the hawkish eyesight to see the incongruent styling. |
jmsmkn
reviewed
Dec 13, 2024
jmsmkn
reviewed
Dec 17, 2024
app/grandchallenge/challenges/static/js/challenges/challenge_costs_overview.mjs
Show resolved
Hide resolved
jmsmkn
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses several issues for the styling of Datatables
Closes #3745
Styling
The PR introduces a few custom CSS styles, overwriting some of the styles found in the bootstrap-4 extension of Datatables.
Leaderboard
The
dom
option is deprecated in Datatables. It had to be updated anyway to account for the new styling. This PR uses the newlayout
option in Datatables to set things up in a future-proof manner.There are four states, as shown below.
Regular
Date & Additional Metrics
Date
Additional Metrics
Other
It also consolidates a few common settings in Datatables:
"nonSortable"
column, employing it in one additional location."string"
of client-side datatables, which indicates: do not transform content when searching/ordering. Also prevents unexpected styles from being applied because of 'automagically' detected content types.