Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several issues with tables update #3745

Closed
jmsmkn opened this issue Dec 12, 2024 · 11 comments · Fixed by #3750
Closed

Several issues with tables update #3745

jmsmkn opened this issue Dec 12, 2024 · 11 comments · Fixed by #3750
Assignees

Comments

@jmsmkn
Copy link
Member

jmsmkn commented Dec 12, 2024

The table alignments are off:

Screenshot 2024-12-12 at 12 48 27

The elements are also all bunched up together, there use to be room around button groups, drop downs, search boxes, and the main table.

@jmsmkn
Copy link
Member Author

jmsmkn commented Dec 12, 2024

This one has data that is right justified in the first column, it shouldn't be:

Screenshot 2024-12-12 at 12 51 14

@jmsmkn
Copy link
Member Author

jmsmkn commented Dec 12, 2024

This one has the previous/next buttons in the middle of the page:

Screenshot 2024-12-12 at 12 53 03

@jmsmkn
Copy link
Member Author

jmsmkn commented Dec 12, 2024

The horizontal rule after the table data is not present in the non-data tables tables, the data table at the bottom should look mostly like the normal one at the top:

Screenshot 2024-12-12 at 12 54 56

@jmsmkn
Copy link
Member Author

jmsmkn commented Dec 12, 2024

The horizontal scroll does not appear after showing all metrics (tested on Safari and Firefox):

Screenshot 2024-12-12 at 12 56 58

@jmsmkn jmsmkn changed the title Tables are cramped and do not take up the full width of parent Several issues with tables update Dec 12, 2024
@chrisvanrun
Copy link
Contributor

The horizontal scroll does not appear after showing all metrics (tested on Safari and Firefox):

Fixed in an existing PR.

@chrisvanrun
Copy link
Contributor

chrisvanrun commented Dec 12, 2024

Looking at the rest now. They're all subtle though =P

@chrisvanrun
Copy link
Contributor

This one has data that is right justified in the first column, it shouldn't be:

Which page was that?

@jmsmkn
Copy link
Member Author

jmsmkn commented Dec 12, 2024

Verification user set.

@chrisvanrun
Copy link
Contributor

Several new 'features' of Datasets are changing the looks a bit. I have a changeset ready that addresses most of them. Will double check it tomorrow and create a PR.

@jmsmkn
Copy link
Member Author

jmsmkn commented Dec 17, 2024

The cost overview page is ordered strangely, it should be double ordered by (1) should be open, (2) most recent submission date:

Screenshot 2024-12-17 at 10 48 46

@chrisvanrun
Copy link
Contributor

The cost overview page is ordered strangely, it should be double ordered by (1) should be open, (2) most recent submission date:

Fixed in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants