-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle submitting multiple messages (cooccurrences) at once #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Pull Request Test Coverage Report for Build 7465454274Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
johnson-liang
force-pushed
the
process-batch
branch
2 times, most recently
from
January 3, 2024 05:48
8400d41
to
4e5e182
Compare
MrOrz
changed the title
feat(webhook): stub for askingCooccurrence
Handle submitting multiple messages (cooccurrences) at once
Jan 3, 2024
johnson-liang
force-pushed
the
process-batch
branch
from
January 3, 2024 10:26
40337d3
to
dfb8cea
Compare
johnson-liang
force-pushed
the
process-batch
branch
from
January 3, 2024 11:11
8c534f4
to
dfb8cea
Compare
bil4444
approved these changes
Jan 3, 2024
MrOrz
force-pushed
the
refactor-search-bubbles
branch
from
January 9, 2024 18:08
2552537
to
6f98e4f
Compare
MrOrz
force-pushed
the
process-batch
branch
2 times, most recently
from
January 9, 2024 18:28
691b070
to
8b30675
Compare
- to avoid user from copying chatbot
…as representative - it is possible that the user do not want to submit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR implements the items with yellow highlight.
We should probably ignore Items with red highlight in the future.
Implement
askingCooccurrences
handler and connect toprocessBatch
processBatch
asks if messages were sent together by the same personaskingCooccurrences
handler handles the user's response.Refactors
Change
askingArticleSubmissionConsent
's input from Yes/No to an array of indexcontext.msgs
that does not in DB and is asking for user's consent for submissionaskingArticleSubmissionConsent
is an empty arrayRevamp logic of
askingArticleSubmissionConsent
context.msgs
UserArticleLink
for newly created messages