Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught error: Can’t apply message of unknown type: 8 on rumors-site #6

Closed
wants to merge 1 commit into from

Conversation

nonumpa
Copy link
Member

@nonumpa nonumpa commented Jan 23, 2024

Error on rumors-site that may break transcript function
image

Reproduce steps: find an article with a transcript, edit the transcript.

Root cause:
It's because we upgraded hocuspocus/server to 2.7.1 in package-lock by accident.
image

And newer version adds a new MessageType which old client does not know

@nonumpa nonumpa requested a review from MrOrz January 23, 2024 14:40
Copy link

github-actions bot commented Jan 23, 2024

Pull Request Test Coverage Report for Build 7629203973

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.063%

Totals Coverage Status
Change from base Build 7474142357: 0.0%
Covered Lines: 44
Relevant Lines: 45

💛 - Coveralls

@johnson-liang
Copy link

Tried editing transcript on https://cofacts.tw/article/8feyM40BAjOeMOkl0o4M and it does not break. Is there any particular steps needed to trigger the error?

Also, should we downgrade as in this PR, or should we update client in rumors-site instead?

…site

It's because we upgraded hocuspocus/server to 2.7.1 in package-lock [by accident](#5).
And newer version adds a new MessageType which old client does not know
@nonumpa nonumpa force-pushed the fix/unknown_message_type_8 branch from 3d45db2 to 2e10f4a Compare January 23, 2024 17:01
@nonumpa
Copy link
Member Author

nonumpa commented Jan 23, 2024

It seems to only break in my devlopment env, and in production, it just keeps logging the error.

I thought it also broke in production, and downgrading is the faster and safer way to fix the bug.
Now I can try to sync the hocuspocus/server version in package.json and upgrade the provider in rumors-stie.

@nonumpa nonumpa closed this Jan 23, 2024
@nonumpa nonumpa mentioned this pull request Mar 28, 2024
@nonumpa nonumpa deleted the fix/unknown_message_type_8 branch April 2, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants