-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage implementation if localStorage is not available #113
Open
GeekaN2
wants to merge
2
commits into
master
Choose a base branch
from
catcher-storage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,153
−857
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
/** | ||
* Implements Web Storage API if localStorage is not available. | ||
* So it can be available in node.js environment | ||
*/ | ||
class CatcherStorage implements Storage { | ||
private items: { [key: string]: string } = {}; | ||
|
||
/** | ||
* Returns the value of the item with the specified key. | ||
* | ||
* @param key - The key of the item you want to retrieve | ||
*/ | ||
public getItem(key: string): string | null { | ||
if (this.isLocalStorageAvailable()) { | ||
return localStorage.getItem(key); | ||
} | ||
|
||
return this.items[key] || null; | ||
} | ||
|
||
/** | ||
* Sets the value of the pair identified by key to value, creating a new key/value pair if none existed for key previously. | ||
* | ||
* @param key - The key of the item you want to store | ||
* @param value - The value of the item you want to store | ||
*/ | ||
public setItem(key: string, value: string): void { | ||
if (this.isLocalStorageAvailable()) { | ||
localStorage.setItem(key, value); | ||
} else { | ||
this.items[key] = value; | ||
} | ||
} | ||
|
||
/** | ||
* Removes the key/value pair with the given key from the list associated with the object, if a key/value pair with the given key exists. | ||
* | ||
* @param key - The key of the item you want to remove | ||
*/ | ||
public removeItem(key: string): void { | ||
if (this.isLocalStorageAvailable()) { | ||
localStorage.removeItem(key); | ||
} else { | ||
delete this.items[key]; | ||
} | ||
} | ||
|
||
/** | ||
* Empties the list associated with the object of all key/value pairs, if there are any. | ||
*/ | ||
public clear(): void { | ||
if (this.isLocalStorageAvailable()) { | ||
localStorage.clear(); | ||
} else { | ||
this.items = {}; | ||
} | ||
} | ||
|
||
/** | ||
* Returns the number of key/value pairs currently present in the list associated with the object. | ||
*/ | ||
public get length(): number { | ||
if (this.isLocalStorageAvailable()) { | ||
return localStorage.length; | ||
} | ||
|
||
return Object.keys(this.items).length; | ||
} | ||
|
||
/** | ||
* Returns the name of the nth key in the list. | ||
* | ||
* @param index - The index of the key you want to get | ||
*/ | ||
public key(index: number): string | null { | ||
if (this.isLocalStorageAvailable()) { | ||
return localStorage.key(index); | ||
} | ||
|
||
return Object.keys(this.items)[index] || null; | ||
} | ||
|
||
/** | ||
* Checks if localStorage is available | ||
*/ | ||
private isLocalStorageAvailable(): boolean { | ||
try { | ||
const testKey = '__test__'; | ||
|
||
localStorage.setItem(testKey, testKey); | ||
localStorage.removeItem(testKey); | ||
|
||
return true; | ||
} catch (e) { | ||
return false; | ||
} | ||
} | ||
} | ||
|
||
export const catcherStorage = new CatcherStorage(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,7 @@ | |
}, | ||
"include": [ | ||
"src/**/*", | ||
"src/types/*" | ||
"src/types/*", | ||
"src/modules/*", | ||
], | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make this class more abstract:
and catcher will set available implementation:
and user can pass own implementation through the catcher initial settings: