-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage implementation if localStorage is not available #113
Open
GeekaN2
wants to merge
2
commits into
master
Choose a base branch
from
catcher-storage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
reviewed
Dec 25, 2024
Comment on lines
+5
to
+27
class CatcherStorage implements Storage { | ||
private items: { [key: string]: string } = {}; | ||
|
||
/** | ||
* Returns the value of the item with the specified key. | ||
* | ||
* @param key - The key of the item you want to retrieve | ||
*/ | ||
public getItem(key: string): string | null { | ||
if (this.isLocalStorageAvailable()) { | ||
return localStorage.getItem(key); | ||
} | ||
|
||
return this.items[key] || null; | ||
} | ||
|
||
/** | ||
* Sets the value of the pair identified by key to value, creating a new key/value pair if none existed for key previously. | ||
* | ||
* @param key - The key of the item you want to store | ||
* @param value - The value of the item you want to store | ||
*/ | ||
public setItem(key: string, value: string): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make this class more abstract:
export interface HawkStorageLike {
getItem: (key: string) => string | undefined;
setItem(key: string) => boolean;
}
export class CatcherStorage {
constructor(private readonly storage: HawkStorageLike){}
getItem(){
return this.storage.getItem()
}
setItem(){
return this.storage.setItem()
}
}
and catcher will set available implementation:
// catcher.ts
prepateStorage(){
const isLocalStorageAvailable = ...
const storageImplementation = isLocalStorageAvailable ? LocalStorage : CustomStorage
this.storage = new CatcherStorage(storageImplementation)
}
and user can pass own implementation through the catcher initial settings:
import { HawkCatcher, type HawkStorageLike } from '@hawk.so/javascript'
class ReactNativeStorage implements HawkStorageLike {
...
}
new HawkCatcher {
//...
storage: new ReactNativeStorge()
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to use catcher in node.js like environment.
Needed for react-native catcher