-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newsfeed UI and Navigation #1651
Changes from all commits
d50083a
1559335
fa8a7b4
35e220e
7c8300b
06e5b17
54846ba
3738a7c
9552ac3
9d1cd26
640c972
82e78df
c2369c1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,18 @@ | ||
import { ReactElement } from "react" | ||
import CardBootstrap from "react-bootstrap/Card" | ||
import styled from "styled-components" | ||
import { Col, Row, Spinner } from "../bootstrap" | ||
import { Timestamp } from "firebase/firestore" | ||
|
||
const AlertCardInnerBodyV2 = styled.div` | ||
background-color: #d1d6e7; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Going to be the same nit on all of these There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also nit: Can this background-color be one of our color variables? I think we're looking to keep these more consistent going forward. |
||
` | ||
|
||
interface AlertCardBodyProps { | ||
imgSrc?: string | ||
imgAltTxt?: string | ||
text: string | ||
timestamp?: string | ||
} | ||
|
||
export const AlertCardBody = (props: AlertCardBodyProps) => { | ||
|
@@ -18,3 +26,33 @@ export const AlertCardBody = (props: AlertCardBodyProps) => { | |
</div> | ||
) | ||
} | ||
|
||
export const AlertCardBodyV2 = (props: AlertCardBodyProps) => { | ||
const { imgSrc, imgAltTxt, text, timestamp } = props | ||
return ( | ||
<div> | ||
<CardBootstrap.Body className={`p-0`}> | ||
<AlertCardInnerBodyV2 | ||
className={`align-items-center d-flex mx-2 mt-1 mb-2 p-2 rounded`} | ||
> | ||
<img | ||
src="\images\clock.svg" | ||
height="105.6" | ||
width="105.6" | ||
alt={imgAltTxt} | ||
className={`m-3`} | ||
/> | ||
<Col className={`m-2`}> | ||
<CardBootstrap.Text className={`mb-0`}> | ||
<strong>{text}</strong> | ||
</CardBootstrap.Text> | ||
<> | ||
{"Action taken on "} | ||
{timestamp} | ||
</> | ||
</Col> | ||
</AlertCardInnerBodyV2> | ||
</CardBootstrap.Body> | ||
</div> | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could we give this a more descriptive name than
AlertCardV2
?NewsfeedBillCard
would work for me for now - we can always generalize the card and name if someone ever needs to use the design in another context.