Newsfeed UI and Navigation #1651
Conversation
mertbagt
requested review from
sashamaryl,
nesanders,
mvictor55,
timblais,
alexjball,
Mephistic and
kiminkim724
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…wsfeed-ui-and-navigation
…wsfeed-ui-and-navigation
| @@ -35,3 +35,42 @@ export const AlertCard = (props: { | |||
|
|
|||
| return <MapleCard headerElement={header} body={body} /> | |||
| } | |||
|
|
|||
| // newsfeed bill card | |||
| export const AlertCardV2 = (props: { | |||
There was a problem hiding this comment.
nit: Could we give this a more descriptive name than AlertCardV2? NewsfeedBillCard would work for me for now - we can always generalize the card and name if someone ever needs to use the design in another context.
| import { Timestamp } from "firebase/firestore" | ||
|
|
||
| const AlertCardInnerBodyV2 = styled.div` | ||
| background-color: #d1d6e7; |
There was a problem hiding this comment.
Going to be the same nit on all of these V2 components - if they're just NewsfeedCard*, let's just name them that to be unambiguous. The props are pretty tied to the newsfeed data model anyway.
There was a problem hiding this comment.
Also nit: Can this background-color be one of our color variables? I think we're looking to keep these more consistent going forward.
| font-size: 61px; | ||
| line-height: 125%; | ||
| font-weight: 700; | ||
| font-size: 40px; |
There was a problem hiding this comment.
nit: if possible, would be nice to use one of our standard bootstrap sizes (and we should start pushing back on designs that deviate from those without due consideration). If not, don't sweat it for now.
Summary
Issues: #1633 and #1641
additional updates to be in follow-on PR when updates to database are made (see Known Issues)
additional follow on PR will attempt to address Pagination
Checklist
Screenshots
Known issues
testimony card redesign is going to need testimony-authorId added to object returned by filteredResults in order to run queries against that to detirmine following status
Steps to test/reproduce
a. mobile nav bar
b. desktop nav bar