Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Quick fixes to release workflow #35

Merged
merged 6 commits into from
Dec 21, 2023
+17 −12
Merged

build: Quick fixes to release workflow #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa9f77f
add pnpm version to prepare-publish workflow
nicholas-codecov Dec 20, 2023
ae3e518
add pnpm version to publish workflow
nicholas-codecov Dec 20, 2023
7539f6c
swap to only patch release
nicholas-codecov Dec 21, 2023
eb479ae
swap to pre-release mode
nicholas-codecov Dec 21, 2023
81babc0
swap pre-release tag to alpha
nicholas-codecov Dec 21, 2023
4645d50
remove alpha from package json
nicholas-codecov Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of this pre.json file seems to be for configuration purposes. It would be helpful if there was a clear change description regarding its need.

"mode": "pre",
"tag": "alpha",
"initialVersions": {
"@codecov/bundler-plugin-core": "0.0.1",
"@codecov/rollup-plugin": "0.0.1",
"@codecov/vite-plugin": "0.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initialVersions field has been initialized as '0.0.1' for each plugin. Make sure this version is the right one to start with.

"@codecov/webpack-plugin": "0.0.1"
},
"changesets": []
}
8 changes: 0 additions & 8 deletions .changeset/sweet-lemons-add.md
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions .github/workflows/prepare-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- name: Setup pnpm & install dependencies
uses: pnpm/action-setup@v2
with:
version: 8
nicholas-codecov marked this conversation as resolved.
Show resolved Hide resolved
run_install: true

- name: Create Release Pull Request
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
- name: Setup pnpm & install dependencies
uses: pnpm/action-setup@v2
with:
version: 8
nicholas-codecov marked this conversation as resolved.
Show resolved Hide resolved
run_install: true

- name: Publish to NPM
Expand Down
2 changes: 1 addition & 1 deletion packages/bundler-plugin-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codecov/bundler-plugin-core",
"version": "0.0.1-alpha",
"version": "0.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version for '@codecov/bundler-plugin-core' has been changed from '0.0.1-alpha' to '0.0.1'. This seems indicative of moving from an alpha pre-release to an actual release.

"description": "Official Codecov Bundler Plugin Core",
"author": "Codecov",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/rollup-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codecov/rollup-plugin",
"version": "0.0.1-alpha",
"version": "0.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version for '@codecov/rollup-plugin' package has been updated from '0.0.1-alpha' to '0.0.1'. Please confirm if this package is ready for production.

"description": "Official Codecov Rollup plugin",
"author": "Codecov",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/vite-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codecov/vite-plugin",
"version": "0.0.1-alpha",
"version": "0.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the '@codecov/vite-plugin' is sufficiently tested and stable before changing its version from the alpha flag.

"description": "Official Codecov Vite plugin",
"author": "Codecov",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/webpack-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codecov/webpack-plugin",
"version": "0.0.1-alpha",
"version": "0.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version update spotted for '@codecov/webpack-plugin' as well. Make sure the versioning is consistent across all packages and they're ready for this change.

"description": "Official Codecov Webpack plugin",
"author": "Codecov",
"license": "MIT",
Expand Down