build: Quick fixes to release workflow #35
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
![codecov[bot]](https://avatars.githubusercontent.com/in/254?s=60&v=4){kind=small}
There was a problem hiding this comment.
In general, the changes are straightforward and seem to be following best practices. However, there may be potential issues in terms of specifying the version number for pnpm. Additionally, repetition of configuration details for pnpm setup could suggest an opportunity for refactoring to improve overall code maintainability and readability.
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
The addition of this pre.json file seems to be for configuration purposes. It would be helpful if there was a clear change description regarding its need.
| "initialVersions": { | ||
| "@codecov/bundler-plugin-core": "0.0.1", | ||
| "@codecov/rollup-plugin": "0.0.1", | ||
| "@codecov/vite-plugin": "0.0.1", |
There was a problem hiding this comment.
The initialVersions field has been initialized as '0.0.1' for each plugin. Make sure this version is the right one to start with.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@codecov/bundler-plugin-core", | |||
| "version": "0.0.1-alpha", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
Version for '@codecov/bundler-plugin-core' has been changed from '0.0.1-alpha' to '0.0.1'. This seems indicative of moving from an alpha pre-release to an actual release.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@codecov/rollup-plugin", | |||
| "version": "0.0.1-alpha", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
Version for '@codecov/rollup-plugin' package has been updated from '0.0.1-alpha' to '0.0.1'. Please confirm if this package is ready for production.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@codecov/vite-plugin", | |||
| "version": "0.0.1-alpha", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
Ensure the '@codecov/vite-plugin' is sufficiently tested and stable before changing its version from the alpha flag.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@codecov/webpack-plugin", | |||
| "version": "0.0.1-alpha", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
Version update spotted for '@codecov/webpack-plugin' as well. Make sure the versioning is consistent across all packages and they're ready for this change.
Description
Missed setting the required pnpm version in the workflows, also swapping over to use changeset pre-release mode.
Found the pre-release info from the changeset docs here, which will tag our releases with a
-alpha.0initially rather then having that done in the package json files themsevles.