Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Fix up peer deps, and keywords in package.json files #32

Merged
merged 3 commits into from
Dec 19, 2023
Merged

meta: Fix up peer deps, and keywords in package.json files #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
797689f
add in keywords and peer deps to rollup package.json file
nicholas-codecov Dec 19, 2023
45b3d03
add in keywords and peer deps to vite package.json file
nicholas-codecov Dec 19, 2023
eda1d80
add in keywords and peer deps to webpack package.json file
nicholas-codecov Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/rollup-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
"description": "Official Codecov Rollup plugin",
"author": "Codecov",
"license": "MIT",
"keywords": [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of keywords for improving package discoverability.

"Codecov",
"Rollup",
"bundler",
"plugin"
],
"type": "module",
"exports": {
".": {
Expand Down Expand Up @@ -50,6 +56,9 @@
"typescript": "^5.3.2",
"unbuild": "^2.0.0"
},
"peerDependencies": {
"rollup": "^3.0 || ^4.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of semantic versioning (^3.0 || ^4.0) for the 'rollup' peer dependency is good.

},
"volta": {
"extends": "../../package.json"
},
Expand Down
9 changes: 9 additions & 0 deletions packages/vite-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
"description": "Official Codecov Vite plugin",
"author": "Codecov",
"license": "MIT",
"keywords": [
"Codecov",
"Vite",
"bundler",
"plugin"
],
"type": "module",
"exports": {
".": {
Expand Down Expand Up @@ -50,6 +56,9 @@
"unbuild": "^2.0.0",
"vite": "5.0.3"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the dependency 'vite' has backward compatibility with versions 4.0 and 5.0 as specified.

"peerDependencies": {
"vite": "^4.0 || ^5.0"
},
"volta": {
"extends": "../../package.json"
},
Expand Down
9 changes: 9 additions & 0 deletions packages/webpack-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
"description": "Official Codecov Webpack plugin",
"author": "Codecov",
"license": "MIT",
"keywords": [
"Codecov",
"Webpack",
"bundler",
"plugin"
],
"type": "module",
"exports": {
".": {
Expand Down Expand Up @@ -51,6 +57,9 @@
"typescript": "^5.3.2",
"unbuild": "^2.0.0"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the peer dependency 'webpack' has backward compatibility with its version 5.0.

"peerDependencies": {
"webpack": "^5.0"
},
"volta": {
"extends": "../../package.json"
},
Expand Down