meta: Fix up peer deps, and keywords in package.json files #32
Conversation
![codecov[bot]](https://avatars.githubusercontent.com/in/254?s=60&v=4){kind=small}
There was a problem hiding this comment.
The Git diff has changes mainly in the package.json file of three packages: 'rollup-plugin', 'vite-plugin', and 'webpack-plugin'. The changes involve adding keywords and declaring peer dependencies, which are both good practices in managing npm packages. The keywords help in searchability of the packages and peer dependencies ensure that these packages can properly execute and function as expected, given the versions of the dependencies specified. There seems to be no critical or serious issues found during the review.
| @@ -4,6 +4,12 @@ | |||
| "description": "Official Codecov Rollup plugin", | |||
| "author": "Codecov", | |||
| "license": "MIT", | |||
| "keywords": [ | |||
There was a problem hiding this comment.
Good use of keywords for improving package discoverability.
| @@ -50,6 +56,9 @@ | |||
| "typescript": "^5.3.2", | |||
| "unbuild": "^2.0.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "rollup": "^3.0 || ^4.0" | |||
There was a problem hiding this comment.
The use of semantic versioning (^3.0 || ^4.0) for the 'rollup' peer dependency is good.
| @@ -50,6 +56,9 @@ | |||
| "unbuild": "^2.0.0", | |||
| "vite": "5.0.3" | |||
| }, | |||
There was a problem hiding this comment.
Ensure that the dependency 'vite' has backward compatibility with versions 4.0 and 5.0 as specified.
| @@ -51,6 +57,9 @@ | |||
| "typescript": "^5.3.2", | |||
| "unbuild": "^2.0.0" | |||
| }, | |||
There was a problem hiding this comment.
Ensure that the peer dependency 'webpack' has backward compatibility with its version 5.0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Description
Quick updates to the bundler plugins
package.jsonfiles to add in keywords, as well as peer deps to ensure that we're running with compatible versions of the bundler.