-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installation: CNF Installation (7) Verify new installation process #2177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't checked the sample CNFs, but i suppose that they should work fine,
Two notes:
df63e7a
to
7621efb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Dummy-tag specs are preparation for step 8 and are meant to fail.
Validate_config spec is failing because of addition of multiple-deployment CNF for dummy-tag tests whilst multiple deployments are not supported yet for regular functionality of testsuite. So, CI failures are expected and don't point to any actual problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
7621efb
to
f06c51f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else lgtm
sample-cnfs/sample_multiple_deployments/memcached/charts/common/templates/_utils.tpl
Outdated
Show resolved
Hide resolved
sample-cnfs/sample_multiple_deployments/memcached/charts/common/templates/_utils.tpl
Outdated
Show resolved
Hide resolved
sample-cnfs/sample_multiple_deployments/nginx/charts/common/templates/_compatibility.tpl
Outdated
Show resolved
Hide resolved
sample-cnfs/sample_multiple_deployments/nginx/charts/common/templates/_resources.tpl
Outdated
Show resolved
Hide resolved
sample-cnfs/sample_multiple_deployments/nginx/charts/common/templates/_resources.tpl
Outdated
Show resolved
Hide resolved
sample-cnfs/sample_multiple_deployments/nginx/charts/common/templates/_resources.tpl
Outdated
Show resolved
Hide resolved
sample-cnfs/sample_multiple_deployments/nginx/charts/common/templates/_resources.tpl
Outdated
Show resolved
Hide resolved
sample-cnfs/sample_multiple_deployments/nginx/charts/common/templates/_resources.tpl
Outdated
Show resolved
Hide resolved
sample-cnfs/sample_multiple_deployments/nginx/charts/common/templates/_utils.tpl
Outdated
Show resolved
Hide resolved
sample-cnfs/sample_multiple_deployments/nginx/charts/common/templates/_utils.tpl
Outdated
Show resolved
Hide resolved
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <[email protected]>
f06c51f
to
8c37d23
Compare
Co-authored-by: Cédric Ollivier <[email protected]>
Description
For reviewers
The "validate_config" and "dummy-tag" spec tests are intentionally failing, this is because we are still blocking multiple deployments in one CNF and they are thus considered invalid, these spec tests will start passing again after #2171. A lot of new sample cnfs were added to test the new installation method making this commit look quite bloated, when reviewing just ignore whatever files that start with
sample-cnfs
(except for the new configs).Issues:
Refs: #2168
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue